You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/26 05:40:00 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #8279: Protect /rendered page from invalid DAG ids (#8171)

mik-laj commented on a change in pull request #8279:
URL: https://github.com/apache/airflow/pull/8279#discussion_r415222730



##########
File path: airflow/www/views.py
##########
@@ -603,13 +603,25 @@ def dag_details(self, session=None):
     def rendered(self):
         dag_id = request.args.get('dag_id')
         task_id = request.args.get('task_id')
+
+        dag = dagbag.get_dag(dag_id)

Review comment:
       Can you change the order of these and next checks? We should not pass parameters to other classes if they don't have the correct format.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org