[GitHub] [iceberg] rdblue commented on a change in pull request #1228: Fix Handling of SparkPartitions with Whitepsace in Location

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1228:
URL: https://github.com/apache/iceberg/pull/1228#discussion_r458916359



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java
##########
@@ -386,7 +386,7 @@ private static SparkPartition toSparkPartition(CatalogTablePartition partition,
     Preconditions.checkArgument(serde.nonEmpty() || table.provider().nonEmpty(),
         "Partition format should be defined");
 
-    String uri = String.valueOf(locationUri.get());
+    URI uri = locationUri.get();

Review comment:
       Looks like the main problem is that `new Path(locationUri.get())` is not the same as `new Path(locationUri.get().toString())`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org