You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2017/05/09 08:14:49 UTC
Review Request 59081: Updated master to use resource provider IDs in
allocator calls.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59081/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Jie Yu.
Repository: mesos
Description
-------
The allocator interface expects resource provider IDs instead of slave
IDs. The internal slave instance in the master will still use their
slave IDs and create a resource provider ID from them to provide
backwards compatibility.
A later patch will change the callbacks of the allocator, until then
the resource provider ID is copied from the slave ID of the callback.
Diffs
-----
src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce
src/master/weights_handler.cpp a4d2fed758878f3e2b9557a61965816aa9e0399c
Diff: https://reviews.apache.org/r/59081/diff/1/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59081: Updated master to use resource provider IDs
in allocator calls.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59081/
-----------------------------------------------------------
(Updated May 31, 2017, 11:56 a.m.)
Review request for mesos, Benjamin Bannier and Jie Yu.
Changes
-------
Fixed `addSlave` call.
Repository: mesos
Description
-------
The allocator interface expects resource provider IDs instead of slave
IDs. The internal slave instance in the master will still use their
slave IDs and create a resource provider ID from them to provide
backwards compatibility.
A later patch will change the callbacks of the allocator, until then
the resource provider ID is copied from the slave ID of the callback.
Diffs (updated)
-----
src/master/http.cpp eb80830fa003ad8f58243d3dc4cec9e03285e96f
src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
src/master/master.cpp 14007e08f509446005423e223d5dd76a70744e27
src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce
src/master/weights_handler.cpp a4d2fed758878f3e2b9557a61965816aa9e0399c
Diff: https://reviews.apache.org/r/59081/diff/2/
Changes: https://reviews.apache.org/r/59081/diff/1-2/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 59081: Updated master to use resource provider IDs
in allocator calls.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59081/#review174311
-----------------------------------------------------------
Bad patch!
Reviews applied: [59081, 58953, 58952, 58951, 58950, 58949]
Failed command: python support/apply-reviews.py -n -r 58950
Error:
2017-05-09 14:51:16 URL:https://reviews.apache.org/r/58950/diff/raw/ [47997/47997] -> "58950.patch" [1]
error: patch failed: src/tests/persistent_volume_endpoints_tests.cpp:1964
error: src/tests/persistent_volume_endpoints_tests.cpp: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/18004/console
- Mesos Reviewbot
On May 9, 2017, 8:14 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59081/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 8:14 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The allocator interface expects resource provider IDs instead of slave
> IDs. The internal slave instance in the master will still use their
> slave IDs and create a resource provider ID from them to provide
> backwards compatibility.
> A later patch will change the callbacks of the allocator, until then
> the resource provider ID is copied from the slave ID of the callback.
>
>
> Diffs
> -----
>
> src/master/http.cpp e2590a17044ac019b24a24629428d4ec8adc0c31
> src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732
> src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad
> src/master/quota_handler.cpp 7fe55808d4561ae5a8850ad904d09a7c65e014ce
> src/master/weights_handler.cpp a4d2fed758878f3e2b9557a61965816aa9e0399c
>
>
> Diff: https://reviews.apache.org/r/59081/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>