You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/09/03 23:25:23 UTC
[GitHub] [datasketches-cpp] jmalkin opened a new pull request #234: Pybind build dependency
jmalkin opened a new pull request #234:
URL: https://github.com/apache/datasketches-cpp/pull/234
Remove pybind11 from source tree and make it a package dependency.
* Provides a package dependency rather than a git submodule
* Specifies a minimum release version rather than pinning to a specific commit
Needed to make some additional cmake changes in order to get Windows to find pybind11, but those seem to work in that we can now successfully build a wheel on all 3 of our CI platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-cpp] jmalkin merged pull request #234: Pybind build dependency
Posted by GitBox <gi...@apache.org>.
jmalkin merged pull request #234:
URL: https://github.com/apache/datasketches-cpp/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org