You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/27 09:03:30 UTC
[GitHub] [incubator-seatunnel] CalvinKirs opened a new pull request #1177: [LICENSE]Add TypeSafe License and mvnw Licenses
CalvinKirs opened a new pull request #1177:
URL: https://github.com/apache/incubator-seatunnel/pull/1177
This is his project (https://lightbend.github.io/config/), he doesn't have a NOTICE File
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] kezhenxu94 commented on a change in pull request #1177: [LICENSE]Add TypeSafe License and mvnw Licenses
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #1177:
URL: https://github.com/apache/incubator-seatunnel/pull/1177#discussion_r793395340
##########
File path: LICENSE
##########
@@ -208,3 +208,9 @@ The following components are provided under the Apache License. See project link
The text of each license is the standard Apache 2.0 license.
tools/dependencies/checkLicense.sh files from https://github.com/apache/skywalking
+mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
+seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigNodePath.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigParser.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/Path.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/PathParser.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/ConfigParseOptions.java from https://github.com/lightbend/config
Review comment:
Let's create some issues to track these files, considering reference by maven module if possible, or review these files and see whether we should revert the license headers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a change in pull request #1177: [LICENSE]Add TypeSafe License and mvnw Licenses
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #1177:
URL: https://github.com/apache/incubator-seatunnel/pull/1177#discussion_r793421774
##########
File path: LICENSE
##########
@@ -208,3 +208,9 @@ The following components are provided under the Apache License. See project link
The text of each license is the standard Apache 2.0 license.
tools/dependencies/checkLicense.sh files from https://github.com/apache/skywalking
+mvnw files from https://github.com/apache/maven-wrapper Apache 2.0
+seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigNodePath.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigParser.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/Path.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/impl/PathParser.java from https://github.com/lightbend/config
+seatunnel-config/src/main/java/com/typesafe/config/ConfigParseOptions.java from https://github.com/lightbend/config
Review comment:
Giving back upstream and getting accepted is a bit difficult, we might try that in the future
thanks for the review, I have restored his file header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1177: [LICENSE]Add TypeSafe License and mvnw Licenses
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1177:
URL: https://github.com/apache/incubator-seatunnel/pull/1177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org