[GitHub] [arrow] pitrou commented on a diff in pull request #14592: ARROW-18253: Add additional bounds safety checks

[GitBox <gi...@apache.org>]

pitrou commented on code in PR #14592:
URL: https://github.com/apache/arrow/pull/14592#discussion_r1014621510


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -203,6 +203,15 @@ class FileReaderImpl : public FileReader {
                         const std::shared_ptr<std::unordered_set<int>>& included_leaves,
                         const std::vector<int>& row_groups,
                         std::unique_ptr<ColumnReaderImpl>* out) {
+    // Should be coverted by GetRecordBatchReader checks but
+    // manifest_.schema_fields, is a separate variable so be extra careful.

Review Comment:
   ```suggestion
       // Should be covered by GetRecordBatchReader checks but
       // manifest_.schema_fields is a separate variable so be extra careful.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org