[GitHub] [helix] kaisun2000 commented on pull request #1456: Fix Periodic rebalancer Timer leak

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1456:
URL: https://github.com/apache/helix/pull/1456#issuecomment-707515096


   One more thing I forget to mention before is this:
   
   The current leaking is caused that two events are push to TaskRebalance thread and HelixRebalance thread at the same time. 
   For this kind of changing the config time period change, in fact, we don't need to put two events to two different thread running task or helix separately. 
   
   All the above is under assumption that periodic rebalance triggering thread (previous timer, now the  is shared by task and now _periodicalRebalanceExecutor. Is there a possibility later that we will use two different (timer)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org