DO NOT REPLY [Bug 34314] - Tiles Request Processor Does Not Catch NoSuchDefinitionException

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34314>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34314





------- Additional Comments From arthur.branham@morganstanley.com  2005-06-16 22:22 -------
(In reply to comment #4)
> I have fixed this in the 1.2.x branch and the current development version. 
> Should be available to try in the next nightly build:
> http://svn.apache.org/builds/struts/maven/

Thank you for the fix on the NoSuchDefinitionException.  So is it acceptable to 
also return a null ComponentDefinition for a call to 
DefinitionsFactory.getDefinition?  I see that you still support that case in 
the TilesRequestProcessor.processTilesDefinition method.  The spec really 
states that a NoSuchDefinitionException should be thrown.  I also notice that 
in the default DefinitionsFactory for tiles 
(org.apache.struts.tiles.xmlDefinition.DefinitionsFactory), the getDefinition 
method does not throw NoSuchDefinitionException - it simply returns the 
ComponentDefinition from the HashMap associated with the given name key. 
Therefore this method never throws NoSuchDefinitionException.  To be consistent 
with your spec you should store the result of the map lookup in a variable, 
check if the variable is null, if null throw a NoSuchDefinitionException. 
  


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org