Re: Review Request 31228: Added a mechanism for disabling http endpoints.

[Alexander Rojas <al...@mesosphere.io>]

> On Feb. 23, 2015, 4:04 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2669
> > <https://reviews.apache.org/r/31228/diff/1/?file=870252#file870252line2669>
> >
> >     We definitely need to document this properly. Suggestions?
> 
> Alexander Rojas wrote:
>     I think it should go wherever we document the environment variables. Can you point to that place?

There's `configuration.md` which would make sense, but it makes no mention of environment variables and `deploy-scripts.md` is the only document mentioning `LIBPROCESS_IP` but it is not where I would add the docs.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31228/#review73568
-----------------------------------------------------------


On Feb. 23, 2015, 6:04 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31228/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 6:04 p.m.)
> 
> 
> Review request for mesos, Joerg Schad, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2333
>     https://issues.apache.org/jira/browse/MESOS-2333
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds a mechanism for disabling http endpoints (e.g `testprocess/handler1,processname(*)/*`). A list of coma separated strings can be provided using the environment variable `LIBPROCESS_DISABLED_ENDPOINTS` which will be read during libprocess initialization. Then, when creating http endpoints (using the method `route`) the endpoint path will be checked against the patterns. If a match is found the endpoint handler will be replaced for a generic once which returns a 403 HTTP Error (Forbidden).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/process.hpp 392c74df3e8a122aecd3633dffdeec4bcbd1f097 
>   3rdparty/libprocess/src/process.cpp 425120b8ef2832f33a13392fe0f397e7b771c0c2 
>   3rdparty/libprocess/src/tests/process_tests.cpp 9f9220ebc05b66b15baa11295fd76c304be3b257 
> 
> Diff: https://reviews.apache.org/r/31228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>