You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/06 16:04:27 UTC
[jira] [Commented] (SLING-4544) Performance: MessageFormat
shouldn't be used for logging in SlingRequestProgressTracker
[ https://issues.apache.org/jira/browse/SLING-4544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14945060#comment-14945060 ]
ASF GitHub Bot commented on SLING-4544:
---------------------------------------
GitHub user joelrich opened a pull request:
https://github.com/apache/sling/pull/104
SLING-4544 - Performance: MessageFormat shouldn't be used for logging…
… in SlingRequestProgressTracker
* Implement fast MessageFormat implementation which falls back to original implementation for complex formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joelrich/sling SLING-4544
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/sling/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit d6702d98284029ec8a726cba22a76e9cdbfba320
Author: Joel Richard <jo...@adobe.com>
Date: 2015-10-06T14:01:33Z
SLING-4544 - Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
* Implement fast MessageFormat implementation which falls back to original implementation for complex formatting
----
> Performance: MessageFormat shouldn't be used for logging in SlingRequestProgressTracker
> ---------------------------------------------------------------------------------------
>
> Key: SLING-4544
> URL: https://issues.apache.org/jira/browse/SLING-4544
> Project: Sling
> Issue Type: Improvement
> Components: Engine
> Affects Versions: Engine 2.4.0
> Reporter: Joel Richard
> Labels: performance
> Attachments: SLING-4544.patch, Screen Shot 2015-03-25 at 10.42.05.png
>
>
> I am profiling an application where 1-5% of the rendering time is spent in MessageFormat.format for SlingRequestProgressTracker.log (see attached screenshot). Since the advanced capabilities of MessageFormat are not required here, it should be rather easy to implement a utility which supports \{x} as well but is much faster.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)