You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Carlos Pita (JIRA)" <ji...@apache.org> on 2008/02/09 21:17:08 UTC
[jira] Created: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
------------------------------------------------------------------------------
Key: WICKET-1332
URL: https://issues.apache.org/jira/browse/WICKET-1332
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.1
Reporter: Carlos Pita
Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
function attachChoiceHandlers(markupid, callbackscript) {
var choiceElementGroup = document.getElementById(markupid);
for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
if (tag == 'input') {
Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
}
}
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570459#action_12570459 ]
Carlos Pita commented on WICKET-1332:
-------------------------------------
Here is a shorter, safer and faster version that uses getElementsByTagName instead of a recursive descent. It also checks for the type of input fields in order to attach handlers just to radios and checkboxes.
asb.append("function attachChoiceHandlers(markupId, callbackScript) {\n");
asb.append(" var inputNodes = wicketGet(markupId).getElementsByTagName('input');\n");
asb.append(" for (var i = 0 ; i < inputNodes.length ; i ++) {\n");
asb.append(" var inputNode = inputNodes[i];\n");
asb.append(" if (!inputNode.type) continue;\n");
asb.append(" var inputType = inputNode.type.toLowerCase();\n");
asb.append(" if (inputType == 'check' || inputType == 'radio') {\n");
asb.append(" Wicket.Event.add(inputNode, 'click', callbackScript);\n");
asb.append(" }\n");
asb.append(" }\n");
asb.append("}\n");
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Matej Knopp
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "renaud houver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
renaud houver updated WICKET-1332:
----------------------------------
Comment: was deleted
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Matej Knopp
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "renaud houver (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12574667#action_12574667 ]
renaud houver commented on WICKET-1332:
---------------------------------------
I do not know if that is related to same issue but I experience that AjaxFormChoiceComponentUpdatingBehavior is not working with a CheckGroup and ListView of Check in version 1.3.0 and 1.3.1. Netiher with above fixed javascript.
But it is working with last version from trunk !!!
Any one knows why ? (looks almost like the attachChoiceHandlers function is commented out in the generated html)
I can't find any related bug that could have fixed that and I'll rather not use trunk version.
Sorry if that is not the right place for that kind of question...
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Matej Knopp
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567378#action_12567378 ]
Carlos Pita commented on WICKET-1332:
-------------------------------------
Igor, here is a version not dependant on prototype, it worked for me but i can't ensure it's bullet proof.
@Override
public void renderHead(IHeaderResponse response) {
super.renderHead(response);
AppendingStringBuffer asb = new AppendingStringBuffer();
asb.append("function attachChoiceHandlers(markupId, callbackScript) {\n");
asb.append(" function attachToDescendants(node) {\n");
asb.append(" var childNodes = node.childNodes;\n");
asb.append(" if (!childNodes) return;\n");
asb.append(" for (var i = 0 ; i < childNodes.length ; i ++) {\n");
asb.append(" var childNode = childNodes[i];\n");
asb.append(" if (childNode.tagName) {\n");
asb.append(" if (childNode.tagName.toLowerCase() == 'input') {\n");
asb.append(" Wicket.Event.add(childNode, 'click', callbackScript);\n");
asb.append(" }\n");
asb.append(" attachToDescendants(childNode);\n");
asb.append(" }\n");
asb.append(" }\n");
asb.append(" }\n");
asb.append(" attachToDescendants(wicketGet(markupId));\n");
asb.append("}\n");
response.renderJavascript(asb, "attachChoice");
response.renderOnLoadJavascript("attachChoiceHandlers('" + getComponent().getMarkupId() +
"', function() {" + getEventHandler() + "});");
}
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Matej Knopp
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581631#action_12581631 ]
Johan Compagner commented on WICKET-1332:
-----------------------------------------
changed that, would be nice to have some unit test for that but thats a bit hard to test...
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1332:
-------------------------------------
Assignee: Matej Knopp
can you whip up some js to handle this?
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Matej Knopp
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner closed WICKET-1332.
-----------------------------------
Resolution: Fixed
i applied that last patch, can everybody test for the different browsers if it works now?
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581603#action_12581603 ]
Carlos Pita commented on WICKET-1332:
-------------------------------------
Johan, after posting this I realized that it should say 'checkbox' instead of 'check', but forgot to comment about it at that time.
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1332:
------------------------------------
Fix Version/s: 1.3.3
Assignee: Johan Compagner (was: Matej Knopp)
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1332)
AjaxFormChoiceComponentUpdatingBehavior just updates the group
"grandchildren"
Posted by "Carlos Pita (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567355#action_12567355 ]
Carlos Pita commented on WICKET-1332:
-------------------------------------
Here is a fix I'm using meanwhile, using proptotype:
function attachChoiceHandlers(markupid, callbackscript) {
$(markupid).descendants().each(function(element) {
if (element && element.tagName) {
if (element.tagName.toLowerCase() == 'input') {
Wicket.Event.add(element, 'click', callbackscript); }
}
});
}
> AjaxFormChoiceComponentUpdatingBehavior just updates the group "grandchildren"
> ------------------------------------------------------------------------------
>
> Key: WICKET-1332
> URL: https://issues.apache.org/jira/browse/WICKET-1332
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.1
> Reporter: Carlos Pita
>
> Up to 1.3.0, there was a bug in that AjaxFormChoiceComponentUpdatingBehavior updated just the group's direct children. Now it generates the header script quoted below, that iterates over the direct children and then over the children of these, triggering the event for the input grandchildren only. So the situation is even worse. I think that attachChoiceHandlers should descend recursively and search for input elements along all the group descendants, not just one arbitrarily chosen level.
> function attachChoiceHandlers(markupid, callbackscript) {
> var choiceElementGroup = document.getElementById(markupid);
> for( var x = 0; x < choiceElementGroup.childNodes.length; x++ ) {
> var choiceElementList = choiceElementGroup.childNodes[x]; for( var y = 0; y < choiceElementList.childNodes.length; y++ ) {
> if (choiceElementList.childNodes[y] && choiceElementList.childNodes[y].tagName) {
> var tag = choiceElementList.childNodes[y].tagName.toLowerCase();
> if (tag == 'input') {
> Wicket.Event.add(choiceElementList.childNodes[y],'click', callbackscript); }
> }
> }
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.