[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #13133: Composite approach for checking in-filter values set in column dictionary

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on code in PR #13133:
URL: https://github.com/apache/druid/pull/13133#discussion_r979218453


##########
processing/src/main/java/org/apache/druid/segment/serde/DictionaryEncodedStringIndexSupplier.java:
##########
@@ -175,6 +177,8 @@ public String getValue(int index)
       extends BaseGenericIndexedDictionaryEncodedIndex<ByteBuffer> implements StringValueSetIndex, Utf8ValueSetIndex
   {
     private static final int SIZE_WORTH_CHECKING_MIN = 8;
+    private static final double SORTED_MERGE_RATIO_THRESHOLD = 0.12D;

Review Comment:
   We could link the issue that has the benchmarks. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org