[GitHub] [helix] mgao0 edited a comment on pull request #1409: Add Builder to ZKDistributedNonblockingLock to enable ZooScalability use

[GitBox <gi...@apache.org>]

mgao0 edited a comment on pull request #1409:
URL: https://github.com/apache/helix/pull/1409#issuecomment-699134667


   Looks good in general. One thing to note: right now you are using the lock path that user passes in directly in the builder. But in the long run, we want to use the LockScope because we would need to support complex lock hierarchies. Can you change the setLockPath to setLockScope?
   -------------------------------------
   On a second thought, let's make both methods available and user can choose which one to use.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org