You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2025/08/22 02:55:17 UTC
[PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
kou opened a new pull request, #47407:
URL: https://github.com/apache/arrow/pull/47407
### Rationale for this change
Snappy 1.2.2 ships this.
### What changes are included in this PR?
Remove needless the Snappy patch.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #47407:
URL: https://github.com/apache/arrow/pull/47407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47407:
URL: https://github.com/apache/arrow/pull/47407#issuecomment-3212861212
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47407:
URL: https://github.com/apache/arrow/pull/47407#issuecomment-3212864663
Revision: 590aae7bcb6cf883f05de7eb3caddd844ec2f78f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a74a99a5e1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a74a99a5e1)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772216/job/48638729996)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772283/job/48638730080)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772203/job/48638729974)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772359/job/48638730254)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17144771928/job/48638729405)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/17144771919/job/48638729388)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772194/job/48638729998)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772062/job/48638729604)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772547/job/48638730688)|
|test-fedora-42-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772108/job/48638729713)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772161/job/48638729826)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/17144771926/job/48638729410)|
|test-ubuntu-22.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17144771945/job/48638729428)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772299/job/48638730124)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772227/job/48638730000)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772455/job/48638730484)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772098/job/48638729746)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772031/job/48638729866)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772324/job/48638730177)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/17144772284/job/48638730074)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/17144771969/job/48638729448)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47407:
URL: https://github.com/apache/arrow/pull/47407#issuecomment-3223152139
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47407:
URL: https://github.com/apache/arrow/pull/47407#issuecomment-3224633708
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1672472be81ff44a27af2259bb3d8fc40e5309fd.
There weren't enough matching historic benchmark results to make a call on whether there were regressions.
The [full Conbench report](https://github.com/apache/arrow/runs/48923951829) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47401: [C++] Remove needless Snappy patch [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #47407:
URL: https://github.com/apache/arrow/pull/47407#issuecomment-3212861487
:warning: GitHub issue #47401 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org