You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by "Victor Dogaru (JIRA)" <ji...@apache.org> on 2016/03/09 22:15:41 UTC

[jira] [Closed] (QUARKS-17) SingleMetricAbstractOplet always creates a metric name

     [ https://issues.apache.org/jira/browse/QUARKS-17?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Victor Dogaru closed QUARKS-17.
-------------------------------
    Resolution: Fixed

Fxed by https://git1-us-west.apache.org/repos/asf?p=incubator-quarks.git;a=commit;h=2ca0f880

> SingleMetricAbstractOplet always creates a metric name
> ------------------------------------------------------
>
>                 Key: QUARKS-17
>                 URL: https://issues.apache.org/jira/browse/QUARKS-17
>             Project: Quarks
>          Issue Type: Bug
>          Components: Runtime, Utils
>            Reporter: Victor Dogaru
>            Assignee: Victor Dogaru
>            Priority: Minor
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> This code (line 42) creates a metric name even when metrics are not enabled, and thus the name is never used. Basically a minor footprint overhead that is not needed.
> {noformat}
>         this.metricName = context.uniquify(shortMetricName);
>         MetricRegistry registry = context.getService(MetricRegistry.class);
>         if (registry != null) {
>             registry.register(getMetricName(), getMetric());
>         }
> {noformat}
> This issue was moved from https://github.com/quarks-edge/quarks/issues/94 .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)