You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "tbw777 (via GitHub)" <gi...@apache.org> on 2023/02/06 17:03:50 UTC
[GitHub] [maven] tbw777 opened a new pull request, #985: Added missing @Deprecated/@deprecated annotations
tbw777 opened a new pull request, #985:
URL: https://github.com/apache/maven/pull/985
@Deprecated annotations helpfully to prevent usage of deprecated API. For example: developer can see crossed out method/field name if this item is deprecated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit closed pull request #985: Added missing @Deprecated/@deprecated annotations
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #985: Added missing @Deprecated/@deprecated annotations
URL: https://github.com/apache/maven/pull/985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] tbw777 commented on pull request #985: Added missing @Deprecated/@deprecated annotations
Posted by "tbw777 (via GitHub)" <gi...@apache.org>.
tbw777 commented on PR #985:
URL: https://github.com/apache/maven/pull/985#issuecomment-1420962960
I can remove all @deprecated and save only @Deprecated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #985: Added missing @Deprecated/@deprecated annotations
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #985:
URL: https://github.com/apache/maven/pull/985#issuecomment-1420958004
> So the tag without a description(what this PR is doing) might not be very useful as the Javadocs are able to show the deprecation
Agreed. I don't see the point. Having meaningful comments (the _why_ and a _migration path_) would be nice, but those should have been added when things were deprecated, it may be difficult to get back in history and understand why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #985: Added missing @Deprecated/@deprecated annotations
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #985:
URL: https://github.com/apache/maven/pull/985#discussion_r1099093034
##########
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##########
@@ -87,6 +87,7 @@ public class MojoDescriptor extends ComponentDescriptor<Mojo> implements Cloneab
* Description with reason of Mojo deprecation. Similar to Javadoc {@code @deprecated}.
* This will trigger a warning when a user tries to use a Mojo marked as deprecated.
*/
+ @Deprecated
Review Comment:
This is wrong. Just wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] yeikel commented on pull request #985: Added missing @Deprecated/@deprecated annotations
Posted by "yeikel (via GitHub)" <gi...@apache.org>.
yeikel commented on PR #985:
URL: https://github.com/apache/maven/pull/985#issuecomment-1419720276
> Why the duplication with Javadoc tags if there is a Java annotation? Where is the benefit? Others I do understand.
This might help : https://stackoverflow.com/questions/20674135/deprecated-vs-deprecated#:~:text=%40deprecated%20is%20a%20javadoc%20tag,conjunction%20to%20the%20%40Deprecated%20annotation.
> [@Deprecated](http://docs.oracle.com/javase/8/docs/api/java/lang/Deprecated.html) is an annotation that is read by the compiler, used to mark a method as deprecated to the compiler and will generate a deprecation compile-time warning if the method is used.
>
> [@deprecated](http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#@deprecated) is a javadoc tag used to provide documentation about the deprecation. You can use it to explain why the method was deprecated and to suggest an alternative. It only makes sense to use this tag in conjunction to the @Deprecated annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org