[GitHub] [kafka] hachikuji commented on a diff in pull request #13227: KAFKA-14693; Kafka node should halt instead of exit

["hachikuji (via GitHub)" <gi...@apache.org>]

hachikuji commented on code in PR #13227:
URL: https://github.com/apache/kafka/pull/13227#discussion_r1103438546


##########
core/src/main/scala/kafka/server/SharedServer.scala:
##########
@@ -60,7 +60,10 @@ class StandardFaultHandlerFactory extends FaultHandlerFactory {
     action: Runnable
   ): FaultHandler = {
     if (fatal) {
-      new ProcessExitingFaultHandler(action)
+      new ProcessTerminatingFaultHandler.Builder()
+        .setHalt(true)

Review Comment:
   nit: `setHalt` reads a bit awkward to me. How about `shouldHalt` or `setHaltOnTerminate`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org