You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by fl...@apache.org on 2018/08/30 14:30:53 UTC
[09/50] tinkerpop git commit: repleace String loop to String builder
repleace String loop to String builder
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/7485ae83
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/7485ae83
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/7485ae83
Branch: refs/heads/TINKERPOP-1774
Commit: 7485ae83266e23a92703e5f277602f213742bdc9
Parents: f49b279
Author: Otavio Santana <ot...@gmail.com>
Authored: Wed Aug 22 09:01:08 2018 -0300
Committer: Otavio Santana <ot...@gmail.com>
Committed: Wed Aug 22 10:04:32 2018 -0300
----------------------------------------------------------------------
.../jsr223/AbstractGremlinScriptEngineFactory.java | 6 +++---
.../process/traversal/dsl/GremlinDslProcessor.java | 12 +++++++-----
.../traversal/util/DefaultTraversalMetrics.java | 14 +++++++-------
3 files changed, 17 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7485ae83/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java
index e07e884..e54b8cc 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/AbstractGremlinScriptEngineFactory.java
@@ -107,12 +107,12 @@ public abstract class AbstractGremlinScriptEngineFactory implements GremlinScrip
*/
@Override
public String getProgram(final String... statements) {
- String program = "";
+ StringBuilder program = new StringBuilder();
for (String statement : statements) {
- program = program + statement + System.lineSeparator();
+ program.append(statement).append(System.lineSeparator());
}
- return program;
+ return program.toString();
}
}
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7485ae83/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java
index ec6379f..e5fd37a 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/GremlinDslProcessor.java
@@ -429,23 +429,25 @@ public class GremlinDslProcessor extends AbstractProcessor {
private void addMethodBody(final MethodSpec.Builder methodToAdd, final ExecutableElement templateMethod,
final String startBody, final String endBody, final Object... statementArgs) {
final List<? extends VariableElement> parameters = templateMethod.getParameters();
- String body = startBody;
+ StringBuilder body = new StringBuilder(startBody);
final int numberOfParams = parameters.size();
for (int ix = 0; ix < numberOfParams; ix++) {
final VariableElement param = parameters.get(ix);
methodToAdd.addParameter(ParameterSpec.get(param));
- body = body + param.getSimpleName();
- if (ix < numberOfParams - 1) body = body + ",";
+ body.append(param.getSimpleName());
+ if (ix < numberOfParams - 1) {
+ body.append(",");
+ }
}
- body = body + endBody;
+ body.append(endBody);
// treat a final array as a varargs param
if (!parameters.isEmpty() && parameters.get(parameters.size() - 1).asType().getKind() == TypeKind.ARRAY)
methodToAdd.varargs(true);
- methodToAdd.addStatement(body, statementArgs);
+ methodToAdd.addStatement(body.toString(), statementArgs);
}
private TypeName getOverridenReturnTypeDefinition(final ClassName returnClazz, final String[] typeValues) {
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/7485ae83/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
index c5f290a..e155ab6 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
@@ -109,14 +109,14 @@ public final class DefaultTraversalMetrics implements TraversalMetrics, Serializ
private void appendMetrics(final Collection<? extends Metrics> metrics, final StringBuilder sb, final int indent) {
// Append each StepMetric's row. indexToLabelMap values are ordered by index.
for (Metrics m : metrics) {
- String rowName = m.getName();
+ StringBuilder rowName = new StringBuilder(m.getName());
// Handle indentation
for (int ii = 0; ii < indent; ii++) {
- rowName = " " + rowName;
+ rowName.insert(0, " ");
}
// Abbreviate if necessary
- rowName = StringUtils.abbreviate(rowName, 50);
+ rowName = new StringBuilder(StringUtils.abbreviate(rowName.toString(), 50));
// Grab the values
final Long itemCount = m.getCount(ELEMENT_COUNT_ID);
@@ -125,7 +125,7 @@ public final class DefaultTraversalMetrics implements TraversalMetrics, Serializ
// Build the row string
- sb.append(String.format("%n%-50s", rowName));
+ sb.append(String.format("%n%-50s", rowName.toString()));
if (itemCount != null) {
sb.append(String.format(" %21d", itemCount));
@@ -187,11 +187,11 @@ public final class DefaultTraversalMetrics implements TraversalMetrics, Serializ
private static String padLeft(final String text, final int amountToPad) {
// not sure why this method needed to exist. stupid string format stuff and commons utilities wouldn't
// work for some reason in the context this method was used above.
- String newText = text;
+ StringBuilder newText = new StringBuilder(text);
for (int ix = 0; ix < amountToPad; ix++) {
- newText = " " + newText;
+ newText.insert(0, " ");
}
- return newText;
+ return newText.toString();
}
private void computeTotals() {