[GitHub] andrzej-kaczmarek commented on a change in pull request #387: nimble/controller: Call ble_ll_conn_init_hcc_params only when needed

[gi...@git.apache.org]

andrzej-kaczmarek commented on a change in pull request #387: nimble/controller: Call ble_ll_conn_init_hcc_params only when needed
URL: https://github.com/apache/mynewt-core/pull/387#discussion_r126114439
 
 

 ##########
 File path: net/nimble/controller/src/ble_ll_conn_hci.c
 ##########
 @@ -724,7 +724,12 @@ ble_ll_ext_conn_create(uint8_t *cmdbuf)
         return BLE_ERR_CONN_LIMIT;
     }
 
-    ble_ll_conn_init_hcc_params(hcc, valid_param_idx);
+    /* Check if we should init some initial parameters which host did not
+     * specified
+     */
+    if (valid_param_idx >= 0) {
 
 Review comment:
   This should be non-zero here anyway. I think the reason why GCC does not catch this properly (btw, for me it builds fine) is because you do initial phy masks validation as if all phys are enabled - perhaps if the initial validation includes phys that are enabled only, it would compile for you.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services