You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/02/24 09:36:33 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3911: kvm:
fix/optimize propogating configs
ustcweizhou opened a new pull request #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911
## Description
<!--- Describe your changes in detail -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
Make some changes based on @nvazquez 's comments in PR #3491
Fix a bug in #3491
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3911: kvm: fix/optimize
propogating configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593792902
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-595085833
no idea, @rhtyd . time skew? you stole apache code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593941383
is this an implementation for #3896 , @weizhouapache ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3911: kvm: fix/optimize
propogating configs
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3911: kvm: fix/optimize
propogating configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-595086590
I certainly did not steal the commit, if you see git history it clearly hints github did the squash+merge. I would blame bug in @github @DaanHoogland. I'll try and use rebase+merge in future where PRs have single commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request
#3911: kvm: fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#discussion_r388063139
##########
File path: core/src/main/java/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java
##########
@@ -319,9 +319,12 @@ private Answer execute(GetDomRVersionCmd cmd) {
}
public boolean configureHostParams(final Map<String, String> params) {
- if (_params.get("router.aggregation.command.each.timeout") == null) {
+ if (_params.get("router.aggregation.command.each.timeout") != null) {
String value = (String)params.get("router.aggregation.command.each.timeout");
- _eachTimeout = Duration.standardSeconds(NumbersUtil.parseInt(value, 10));
+ _eachTimeout = Duration.standardSeconds(NumbersUtil.parseLong(value, 600));
Review comment:
I am +1 on externalizing 600 into a constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-594033213
<b>Trillian test result (tid-1175)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28303 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3911-t1175-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_vpc_privategw_static_routes | `Failure` | 174.22 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 173.28 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 238.77 | test_privategw_acl.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593816216
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3911: kvm: fix/optimize
propogating configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-594359458
@nvazquez can you review? cc @DaanHoogland @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593793095
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd commented on issue #3911: kvm: fix/optimize
propogating configs
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-595063239
I'm not sure what happened, I squashed merge this PR on 4.13 and the commit now says I authored it. What just happened cc @ustcweizhou @weizhouapache @DaanHoogland @andrijapanicsb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593810352
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-593816353
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3911: kvm:
fix/optimize propogating configs
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3911: kvm: fix/optimize propogating configs
URL: https://github.com/apache/cloudstack/pull/3911#issuecomment-595087259
i wouldn't worry to much @rhtyd . let's keep an eye out on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services