Re: svn commit: r27304 - trunk/subversion/bindings/swig/perl/native

["Daniel L. Rall" <dl...@finemaltcoding.com>]

On Mon, 22 Oct 2007, arfrever@tigris.org wrote:

> Author: arfrever
> Date: Mon Oct 22 00:00:25 2007
> New Revision: 27304
> 
> Log:
> Respect CPPFLAGS in Perl bindings.
> 
> * subversion/bindings/swig/perl/native/Makefile.PL.in: Set cppflags to CPPFLAGS, and use cppflags in config.
> 
> Patch by: arfrever
> Review by: dlr

This should be:

  Approved by: dlr

...and leave off the "Patch by" bit, which is assumed to be the committer,
if not listed.

> 
> 
> Modified:
>    trunk/subversion/bindings/swig/perl/native/Makefile.PL.in
> 
> Modified: trunk/subversion/bindings/swig/perl/native/Makefile.PL.in
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/perl/native/Makefile.PL.in?pathrev=27304&r1=27303&r2=27304
> ==============================================================================
> --- trunk/subversion/bindings/swig/perl/native/Makefile.PL.in	(original)
> +++ trunk/subversion/bindings/swig/perl/native/Makefile.PL.in	Mon Oct 22 00:00:25 2007
> @@ -26,6 +26,7 @@
>  my @ldmodules = map {"-lsvn_$_-1"} (@modules, qw/diff subr/);
>  
>  my $apr_shlib_path_var = '@SVN_APR_SHLIB_PATH_VAR@';
> +my $cppflags = '@CPPFLAGS@';
>  my $apr_cflags = '@SVN_APR_INCLUDES@';
>  my $apu_cflags = '@SVN_APRUTIL_INCLUDES@';
>  
> @@ -38,6 +39,7 @@
>  
>  my %config = (
>      ABSTRACT => 'Perl bindings for Subversion',
> +    DEFINE => $cppflags,
>      INC  => join(' ',$apr_cflags, $apu_cflags, 
>                   " -I$swig_srcdir/perl/libsvn_swig_perl",
>                   " -I$svnlib_srcdir/include",
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

-- 

Daniel Rall