[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10172: fix: make auth for hive optional

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #10172:
URL: https://github.com/apache/incubator-superset/pull/10172#discussion_r446395434



##########
File path: superset/db_engine_specs/hive.py
##########
@@ -437,14 +437,9 @@ def get_configuration_for_impersonation(
         url = make_url(uri)
         backend_name = url.get_backend_name()
 
-        # Must be Hive connection, enable impersonation, and set param
+        # Must be Hive connection, enable impersonation, and set optional param
         # auth=LDAP|KERBEROS
-        if (
-            backend_name == "hive"
-            and "auth" in url.query.keys()
-            and impersonate_user is True
-            and username is not None
-        ):
+        if backend_name == "hive" and impersonate_user is True and username is not None:

Review comment:
       Could you also replace `impersonate_user is True` with `impersonate_user`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org