You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/10 20:30:20 UTC

[GitHub] [superset] john-bodley opened a new issue #11680: Owner names not rendered in React Datasource editor

john-bodley opened a new issue #11680:
URL: https://github.com/apache/superset/issues/11680

### Expected results

The dataset owners should be rendered.

### Actual results

#### How to reproduce the bug

1. Go to a chart.
2. Click on 'Edit Datasource'
3. Click on the 'SETTINGS' tab
4. Scroll to the bottom and and noticed that the owner names aren't rendered

### Environment

(please complete the following information):

- superset version: `master`
- python version: `3.7`
- node.js version: `12`

### Checklist

Make sure to follow these steps before submitting your issue - thank you!

- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codenamelxl edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   Changing this into `api/v1/dataset/related/owners?q=(page_size:2000)`  will be a quick fix.  https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/datasource/DatasourceEditor.jsx#L629
   
   Side issue: No request to /dataset/related/owner was made when typing into Owner field as well.
   Behavior for Chart and Dashboard is it trigger /related/owner  on every keytype.
   This is due to: https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/components/AsyncSelect/index.jsx#L88 using Select instead of AsyncSelect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] amitmiran137 closed issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

amitmiran137 closed issue #11680:
URL: https://github.com/apache/superset/issues/11680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codenamelxl commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   It also does not trigger Async load for user name when typing to add new user in the Owner. No request to /dataset/related/owner was made on typing to the Owner in Datasource Editor.
   Behavior for Chart and Dashboard is it trigger /related/owner  on every keytype.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1032089524


   this appears to be fixed in the latest version (1.4.0)? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364

@etr2460 I don't think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owners in the Datasource settings. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is not merged yet so this might be a good opportunity to think about doing it, depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlincc

There is another implementation which is using the paginated fetch instead and that's in the Properties modal. I have an env with more than 10 owners (10 as a pagesize limit) and could not spot any problem. I am about to merge this PR containing the changes. This can be a good opportunity to validate this issue against the new implementation https://github.com/apache/superset/pull/16445.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364


   @etr2460 I don't think MY current implementation would work. You can check the code in this PR https://github.com/apache/superset/pull/16609. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization. CC @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codenamelxl edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   Changing this into `api/v1/dataset/related/owners?q=(page_size:2000)`  will be a quick fix.  https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/datasource/DatasourceEditor.jsx#L629
   
   Side issue: No request to `/dataset/related/owners` was made when typing into Owner field as well.
   Behavior for Chart and Dashboard is it trigger `/related/owners`  on every keytype.
   This is due to: https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/components/AsyncSelect/index.jsx#L88 using Select instead of AsyncSelect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1032094703


   Yup, looks like it was fixed by https://github.com/apache/superset/pull/17063


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

etr2460 commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-891327827


   Hey @amitmiran137 , is Neilsen still planning on working on this? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364

@etr2460 I don't think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owner in the Datasource settings. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlincc

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] codenamelxl edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   No request to /dataset/related/owner was made when typing into Owner field as well.
   Behavior for Chart and Dashboard is it trigger /related/owner  on every keytype.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364

@etr2460 I don't think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owner in the Datasource settings. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlincc

There is another implementation which is using the paginated fetch instead and that's in the Properties modal. I have an env with more than 10 owners (10 is the default page size of the new Select) and could not spot any problem. I am about to merge this PR containing the changes. This can be a good opportunity to validate this issue against the new implementation https://github.com/apache/superset/pull/16445.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] nytai edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1009321691


   The call to fetch owners is `/api/v1/dataset/related/owners` which is falling back to the FAB default limit of 20 (https://github.com/dpgaspar/Flask-AppBuilder/blob/314c3482b067f2fd3a2b29c222a2c1a8410d61e6/flask_appbuilder/api/__init__.py#L959)
   
   In order to repro this bug, you will need:
   1. To have more than 20 possible owner values
   2. Set an owner.
   3. Make sure the set owner is not part of the initial call that fetches 20 results.
   4. You will see the empty select option


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1009321691


   The call to fetch owners is `/api/v1/dataset/related/owners` which is falling back to the FAB default limit of 20 (https://github.com/dpgaspar/Flask-AppBuilder/blob/314c3482b067f2fd3a2b29c222a2c1a8410d61e6/flask_appbuilder/api/__init__.py#L959)
   
   In order to repro this bug, you will need:
   1. To have more than 20 possible owner values
   2. Set an owner.
   3. Make sure the set owner is not part of the initial call that fetches 20 results (might be easier to just set all users as owners).
   4. You will see the empty select option


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364


   @etr2460 I don't think the current implementation would work. You can check the code in this PR https://github.com/apache/superset/pull/16609. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization. CC @junlincc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codenamelxl edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   No request to /dataset/related/owner was made when typing into Owner field as well.
   Behavior for Chart and Dashboard is it trigger /related/owner  on every keytype.
   This is due to: https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/components/AsyncSelect/index.jsx#L88 using Select instead of AsyncSelect. Can be considered as a separated issue.
   
   For anyone come by this issue: Changing this into `api/v1/dataset/related/owners?q=(page_size:2000)`  will be a quick fix.  https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/datasource/DatasourceEditor.jsx#L629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-983617903


   @junlincc @nytai Can you add some context about the reopening of this issue? I just checked it on master and it seems to be working as intended. I simulated a page with 10 results.
   
   https://user-images.githubusercontent.com/70410625/144238905-286e81a8-8321-4e05-84dd-982d2d02526f.mov
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] michael-s-molina commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

michael-s-molina commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927850375


   > @michael-s-molina do you think this is something that your async select work could help with? This seems to be a regression dating back to the original Antd refactor
   
   @etr2460 Yes. I'm tagging @geido here because he worked on this migration and has the full context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] codenamelxl edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

codenamelxl edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-880711917


   Changing this into `api/v1/dataset/related/owners?q=(page_size:2000)`  will be a quick fix.  https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/datasource/DatasourceEditor.jsx#L629
   
   Side issue: No request to `/dataset/related/owners` was made when typing into Owner field as well.
   Behavior for Chart and Dashboard is it trigger /related/owner  on every keytype.
   This is due to: https://github.com/apache/superset/blob/b489cffb570c4d078ec982fd11c3e46dd0310f24/superset-frontend/src/components/AsyncSelect/index.jsx#L88 using Select instead of AsyncSelect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-982126914


   there is a workaround to use the Legacy Datasource Editor. Aside from the list of owners not being rendered properly, this bug does block adding new owners beyond the 10 that are initially fetched which is a major issue. This should be fixed before we fully deprecate the legacy FAB views


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai closed issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai closed issue #11680:
URL: https://github.com/apache/superset/issues/11680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] junlincc closed issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

junlincc closed issue #11680:
URL: https://github.com/apache/superset/issues/11680


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1009321691


   The call to fetch owners is `https://superset.aiml.apple.com/api/v1/dataset/related/owners` which is falling back to the FAB default limit of 20 (https://github.com/dpgaspar/Flask-AppBuilder/blob/314c3482b067f2fd3a2b29c222a2c1a8410d61e6/flask_appbuilder/api/__init__.py#L959)
   
   In order to repro this bug, you will need:
   1. To have more than 20 possible owner values
   2. Set an owner.
   3. Make sure the set owner is not part of the initial call that fetches 20 results.
   4. You will see the empty select option


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1009321691


   The call to fetch owners is `https://superset.aiml.apple.com/api/v1/dataset/related/owners` which is falling back to the FAB default limit of 20. Other Select components have pagination enabled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-1009316000


   This is still an issue. @michael-s-molina please try with > 25 results 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726388536


   @rusackas I believe this regression may be related to a recent change from Preset related to the Antd refactor. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] zuzana-vej commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

zuzana-vej commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-788524022


   FYI, the above linked PR didn't resolve the issue.
   
   See owners on "Edit Dataset" modal in Explore:
   ![Screen Shot 2021-03-01 at 6 14 12 PM](https://user-images.githubusercontent.com/61221714/109586495-277de580-7aba-11eb-8d3b-078d02b69232.png)
   
   See owners on the Data --> Dataset page for same dataset
   ![Screen Shot 2021-03-01 at 6 14 59 PM](https://user-images.githubusercontent.com/61221714/109586482-25b42200-7aba-11eb-959b-3b6350653bd1.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] geido edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

geido edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-927912364

@etr2460 I don't think my current implementation would work for the Datasource settings specifically. You can check the code in this PR https://github.com/apache/superset/pull/16609 that is related to the owner in the Datasource settings. Basically, we would need a refactor of the `SelectAsyncControl` to work with the pagination. That PR is still not merged so this might be a good opportunity to think about doing it depending on prioritization OR we can increase the pagesize to a high limit as a quick fix as suggested above. CC @junlincc

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-982126914


   there is a workaround to use the Legacy Datasource Editor, but this bug does block adding new owners beyond the 10 that are initially fetched. This should be fixed before we fully deprecate the legacy FAB views


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] nytai edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai edited a comment on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-982126914


   there is a workaround to use the Legacy Datasource Editor. Aside from the list of owners not being rendered properly, this bug does block adding new owners beyond the 25 that are initially fetched which is a major issue. This should be fixed before we fully deprecate the legacy FAB views


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

etr2460 commented on issue #11680:
URL: https://github.com/apache/superset/issues/11680#issuecomment-926850890


   @michael-s-molina do you think this is something that your async select work could help with? This seems to be a regression dating back to the original Antd refactor


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

dpgaspar commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-748265371


   We will probably go with `page_size=2000`, and address this properly next. A possible solution is to create a small feature on the generic related endpoint to support something like:
   ```
   {"filter": "<text to filter>", "ids": [1,2,4,n], page:X, page_size:Y}
   ```
   Where the endpoint would get filtered paginated data and make sure the requested ids were included on the response also. At a probable cost of a further query but still more efficient then sending back a very large payload
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

rusackas commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726388986


   @kgabryje 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

kgabryje commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-732104639


   @nytai I think your guess is correct - I could reproduce John's bug by limiting a page size.
   I wonder if paginated endpoint has any value for us in this case? We always need to load all options to make sure that we can display all selected values. Unless we implemented some logic "keep loading next pages until all saved values have a matching option" - though it doesn't sound like this optimization is worth the effort.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-748255335


   We could also send the request with `page_size=2000` or something large enough to solve this issue for most practical cases. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

junlincc edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726394256


   <img width="871" alt="Screen Shot 2020-11-12 at 2 59 49 PM" src="https://user-images.githubusercontent.com/67837651/99006755-cffe3e80-24f7-11eb-8e35-7c68896bb13e.png">
   @john-bodley hey John, im not able to reproduce it, do you have an idea which PR might cause it and when did you first notice it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726403613


   @junlincc unsure. We believe this regression may have been introduced in one of [these changes](https://github.com/airbnb/incubator-superset/compare/release--0.92.2%E2%80%A6airbnb:release--0.93).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-728415874


   @junlincc I'm going to see if the issue is present in our internal weekly deploy which occurs on Wednesday. If it's resolved it's likely our last week branch cut did not contain the commit and I'll close the issue, otherwise I'll dig into this in more detail. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726394256


   <img width="871" alt="Screen Shot 2020-11-12 at 2 59 49 PM" src="https://user-images.githubusercontent.com/67837651/99006755-cffe3e80-24f7-11eb-8e35-7c68896bb13e.png">
   @john-bodley hey John, im not able to reproduce it, do you have an idea which PR might cause it and when did you first noticed it? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

graceguo-supercat commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-730017273


   I found another JS bug for owners selector (besides the issue John just reported). this can be easily reproduced in open source master branch: 
   - you add one more name in the owners list
   - you remove all owners one by one. on removal the last one from owners list, you will see js error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

rusackas commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726434024


   > @junlincc unsure. We believe this regression may have been introduced in one of [these changes](https://github.com/airbnb/incubator-superset/compare/release--0.92.2%E2%80%A6airbnb:release--0.93).
   
   I'm not able to repro this either yet. I would try a little `git bisect` action, but I need a failing state to do so. :/


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

etr2460 commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-747633982


   @nytai @kgabryje @junlincc:
   
   Are there any updates on resolving this? It seems like Tai had a few options for fixing the problem, is anything else blocking trying to fix it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-731471573


   One difference is that `/api/v1/dataset/related/owners` is paginated (with `pageSize` and `pageIndex` params) while I'm guessing `/users/api/read` is not paginated. My guess is that airbnb is hitting this issue because they have >25 users which is the default page size. The `/api/v1/dataset/related/owners` also supports searching via `filter` param. 
   
   
   My guess is that because the existing owners is not in the list of select options it's resulting in this weird rendering issue. We may want to consider just switching back to `/users/api/read` or trying to use the [pagianted select component](https://github.com/apache/incubator-superset/blob/fbe4a6622e0affd6568ba0d5c429dc6bec18f626/superset-frontend/src/components/Select/SupersetStyledSelect.tsx#L295) which may fix this issue 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

kgabryje edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-731252881


   @john-bodley I think that this issue might have been introduced by https://github.com/apache/incubator-superset/pull/11221. I'm not able to verify it as I can't directly reproduce this bug with my test data. Is it possible that the new endpoint `api/v1/dataset/related/owners` returns fewer owners than the old `/users/api/read` and your data actually uses the missing users? Could you please verify it?
   CC @lilykuang @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

kgabryje commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-731252881


   @john-bodley I think that this issue might have been introduced by https://github.com/apache/incubator-superset/pull/11221. I'm not able to verify it as I can't directly reproduce this issue with my test data. Is it possible that the new endpoint `api/v1/dataset/related/owners` returns fewer owners than the old `/users/api/read` and your data actually uses the missing users? Could you please verify it?
   CC @lilykuang @junlincc 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] kgabryje commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

kgabryje commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-730259094


   @junlincc Can you assign me please?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726455046


   @john-bodley could you help narrow it down a bit 🙏 
   
   > > @junlincc unsure. We believe this regression may have been introduced in one of [these changes](https://github.com/airbnb/incubator-superset/compare/release--0.92.2%E2%80%A6airbnb:release--0.93).
   > 
   > I'm not able to repro this either yet. I would try a little `git bisect` action, but I need a failing state to do so. :/
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

rusackas commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-726389257


   Thanks John, will investigate.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-729881747


   @junlincc and @rusackas I'm able to reproduce this from `master` using our production data. It seems like the issue is the fetched set of potential owners is quite restricted (the CRUD view fetches all users) and the prescribed owners are not within said set and thus the labels aren't rendered. 
   
   The logic is defined [here](https://github.com/apache/incubator-superset/blob/55a3404b71232a1cfd6d978f666945cde37c99e2/superset-frontend/src/datasource/DatasourceEditor.jsx#L544-L552) and I only see one request to the `api/v1/dataset/related/owners` endpoint regardless of the typeahead state.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] junlincc commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

junlincc commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-729893874


   @john-bodley thanks for the additional info we are looking into it! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-730017273


   I found another JS bug for owners selector (besides the issue John just reported). this can be easily reproduced in open source master branch: 
   1. add one more name in the owners list
   1. then remove all owners one by one. on removal the last one from owners list, you will see js error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-731402127


   @dpgaspar do you know of any differences between the `/api/v1/dataset/related/owners` and `/users/api/read` API endpoints?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-730017273


   I found another JS bug for owners selector (besides the issue John just reported). this can be easily reproduced in open source master branch: 
   1. you add one more name in the owners list
   1. you remove all owners one by one. on removal the last one from owners list, you will see js error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

john-bodley edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-729881747


   @junlincc and @rusackas I'm able to reproduce this from `master` using our production data. It seems like the issue is the fetched set of potential owners is quite restricted (the CRUD view fetches all users) and the prescribed owners are not within said set and thus the labels aren't rendered. My hunch is you may not be able to repo it as the corpus of users is defined entirely within the null state response. 
   
   The logic is defined [here](https://github.com/apache/incubator-superset/blob/55a3404b71232a1cfd6d978f666945cde37c99e2/superset-frontend/src/datasource/DatasourceEditor.jsx#L544-L552) and I only see one request to the `api/v1/dataset/related/owners` endpoint regardless of the typeahead state.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

nytai commented on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-747768741


   @kgabryje That's a great question. I have spend quite a bit of time working around this (adding `PaginatedSelect`) and have often questioned the value of paginating these payloads. @dpgaspar do you have any thoughts around removing pagination for these endpoints? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat edited a comment on issue #11680: Owner names not rendered in React Datasource editor

Posted by GitBox <gi...@apache.org>.

graceguo-supercat edited a comment on issue #11680:
URL: https://github.com/apache/incubator-superset/issues/11680#issuecomment-730017273


   I found another JS bug for owners selector (besides the issue John just reported). this can be easily reproduced in open source master branch: 
   1. if the owners list is empty, add one or more names in the owners list.
   1. then remove all owners one by one. on removal the last one from owners list, you will see js error.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org