[GitHub] [kafka] mumrah commented on a diff in pull request #13732: KAFKA-15007: Always update the MetadataPropagator with correct MV.

["mumrah (via GitHub)" <gi...@apache.org>]

mumrah commented on code in PR #13732:
URL: https://github.com/apache/kafka/pull/13732#discussion_r1200868934


##########
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##########
@@ -70,7 +68,7 @@ class MigrationPropagator(
   val requestBatch = new MigrationPropagatorBatch(
     config,
     metadataProvider,
-    () => metadataVersion,
+    () => _image.features().metadataVersion(),

Review Comment:
   One subtle difference in behavior here is that the MV of the empty image is IBP_3_0_IV1, so the default we previously had of `IBP_3_4_IV0` is no longer seen. 
   
   However.. I don't think we actually hit these defaults in practice since we won't call the metadata propagator until we've seen at least one metadata publish. @akhileshchg can you confirm if my assumption is correct?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org