You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "reluxa (via GitHub)" <gi...@apache.org> on 2023/06/05 11:05:59 UTC
[GitHub] [fineract] reluxa opened a new pull request, #3227: Fineract 1926 storing balances at ownership transfer
reluxa opened a new pull request, #3227:
URL: https://github.com/apache/fineract/pull/3227
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3227:
URL: https://github.com/apache/fineract/pull/3227#discussion_r1218085846
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferDetails.java:
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.domain;
+
+import java.math.BigDecimal;
+import javax.persistence.CascadeType;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.JoinColumn;
+import javax.persistence.OneToOne;
+import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import org.apache.fineract.infrastructure.core.domain.AbstractAuditableWithUTCDateTimeCustom;
+
+@Getter
+@Setter
+@Table(name = "m_external_asset_owner_transfer_details")
+@NoArgsConstructor
+@Entity
+public class ExternalAssetOwnerTransferDetails extends AbstractAuditableWithUTCDateTimeCustom {
+
+ @OneToOne(cascade = CascadeType.ALL)
+ @JoinColumn(name = "asset_owner_transfer_id", referencedColumnName = "id")
+ private ExternalAssetOwnerTransfer externalAssetOwnerTransfer;
+
+ @Column(name = "total_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalOutstanding;
+
+ @Column(name = "principal_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalPrincipalOutstanding;
+
+ @Column(name = "interest_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalInterestOutstanding;
+
+ @Column(name = "fee_charges_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalFeeChargesOutstanding;
+
+ @Column(name = "penalty_charges_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalPenaltyChargesOutstanding;
+
+ @Column(name = "total_overpaid_derived", scale = 6, precision = 19)
Review Comment:
is there a reason this one can be null? (above fields are all not nullable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3227:
URL: https://github.com/apache/fineract/pull/3227#discussion_r1218088673
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferDetails.java:
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.domain;
+
+import java.math.BigDecimal;
+import javax.persistence.CascadeType;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.JoinColumn;
+import javax.persistence.OneToOne;
+import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import org.apache.fineract.infrastructure.core.domain.AbstractAuditableWithUTCDateTimeCustom;
+
+@Getter
+@Setter
+@Table(name = "m_external_asset_owner_transfer_details")
+@NoArgsConstructor
+@Entity
+public class ExternalAssetOwnerTransferDetails extends AbstractAuditableWithUTCDateTimeCustom {
+
Review Comment:
Please dont forget the tests. Feel free to enhance the existing ones:
`InitiateExternalAssetOwnerTransferTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on a diff in pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #3227:
URL: https://github.com/apache/fineract/pull/3227#discussion_r1218086817
##########
fineract-investor/src/main/resources/db/changelog/tenant/module/investor/parts/0007_add_external_asset_owner_transfer_details.xml:
##########
@@ -0,0 +1,65 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+
+ <!-- Create the m_external_asset_owner_transfer_balance table -->
+ <changeSet author="fineract" id="1" context="postgresql">
+ <createTable tableName="m_external_asset_owner_transfer_details">
+
+ <column autoIncrement="true" name="id" type="BIGINT" remarks="Internal ID">
+ <constraints nullable="false" primaryKey="true"/>
+ </column>
+
+ <column name="asset_owner_transfer_id" type="BIGINT" remarks="Id of asset owner transfer">
+ <constraints nullable="false" unique="true"
+ uniqueConstraintName="UQ_external_asset_owner_transfer_id"/>
+ </column>
+
+ <column name="total_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="principal_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="interest_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="fee_charges_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="penalty_charges_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="total_overpaid_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+
+ <column name="created_by" type="BIGINT" />
+ <column name="created_on_utc" type="TIMESTAMP WITH TIME ZONE" />
+ <column name="last_modified_by" type="BIGINT" />
+ <column name="last_modified_on_utc" type="TIMESTAMP WITH TIME ZONE" />
+ </createTable>
+ </changeSet>
Review Comment:
please dont forget the changeset for mysql/mariadb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] reluxa commented on a diff in pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3227:
URL: https://github.com/apache/fineract/pull/3227#discussion_r1219692537
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferDetails.java:
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.domain;
+
+import java.math.BigDecimal;
+import javax.persistence.CascadeType;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.JoinColumn;
+import javax.persistence.OneToOne;
+import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import org.apache.fineract.infrastructure.core.domain.AbstractAuditableWithUTCDateTimeCustom;
+
+@Getter
+@Setter
+@Table(name = "m_external_asset_owner_transfer_details")
+@NoArgsConstructor
+@Entity
+public class ExternalAssetOwnerTransferDetails extends AbstractAuditableWithUTCDateTimeCustom {
+
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] reluxa commented on a diff in pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "reluxa (via GitHub)" <gi...@apache.org>.
reluxa commented on code in PR #3227:
URL: https://github.com/apache/fineract/pull/3227#discussion_r1219691949
##########
fineract-investor/src/main/java/org/apache/fineract/investor/domain/ExternalAssetOwnerTransferDetails.java:
##########
@@ -0,0 +1,61 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.investor.domain;
+
+import java.math.BigDecimal;
+import javax.persistence.CascadeType;
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.JoinColumn;
+import javax.persistence.OneToOne;
+import javax.persistence.Table;
+import lombok.Getter;
+import lombok.NoArgsConstructor;
+import lombok.Setter;
+import org.apache.fineract.infrastructure.core.domain.AbstractAuditableWithUTCDateTimeCustom;
+
+@Getter
+@Setter
+@Table(name = "m_external_asset_owner_transfer_details")
+@NoArgsConstructor
+@Entity
+public class ExternalAssetOwnerTransferDetails extends AbstractAuditableWithUTCDateTimeCustom {
+
+ @OneToOne(cascade = CascadeType.ALL)
+ @JoinColumn(name = "asset_owner_transfer_id", referencedColumnName = "id")
+ private ExternalAssetOwnerTransfer externalAssetOwnerTransfer;
+
+ @Column(name = "total_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalOutstanding;
+
+ @Column(name = "principal_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalPrincipalOutstanding;
+
+ @Column(name = "interest_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalInterestOutstanding;
+
+ @Column(name = "fee_charges_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalFeeChargesOutstanding;
+
+ @Column(name = "penalty_charges_outstanding_derived", scale = 6, precision = 19, nullable = false)
+ private BigDecimal totalPenaltyChargesOutstanding;
+
+ @Column(name = "total_overpaid_derived", scale = 6, precision = 19)
Review Comment:
done
##########
fineract-investor/src/main/resources/db/changelog/tenant/module/investor/parts/0007_add_external_asset_owner_transfer_details.xml:
##########
@@ -0,0 +1,65 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+
+ <!-- Create the m_external_asset_owner_transfer_balance table -->
+ <changeSet author="fineract" id="1" context="postgresql">
+ <createTable tableName="m_external_asset_owner_transfer_details">
+
+ <column autoIncrement="true" name="id" type="BIGINT" remarks="Internal ID">
+ <constraints nullable="false" primaryKey="true"/>
+ </column>
+
+ <column name="asset_owner_transfer_id" type="BIGINT" remarks="Id of asset owner transfer">
+ <constraints nullable="false" unique="true"
+ uniqueConstraintName="UQ_external_asset_owner_transfer_id"/>
+ </column>
+
+ <column name="total_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="principal_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="interest_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="fee_charges_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="penalty_charges_outstanding_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+ <column name="total_overpaid_derived" type="DECIMAL(19, 6)">
+ <constraints nullable="false"/>
+ </column>
+
+ <column name="created_by" type="BIGINT" />
+ <column name="created_on_utc" type="TIMESTAMP WITH TIME ZONE" />
+ <column name="last_modified_by" type="BIGINT" />
+ <column name="last_modified_on_utc" type="TIMESTAMP WITH TIME ZONE" />
+ </createTable>
+ </changeSet>
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy merged pull request #3227: FINERACT-1926 storing balances at ownership transfer
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #3227:
URL: https://github.com/apache/fineract/pull/3227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org