[GitHub] [incubator-pinot] jasperjiaguo commented on a change in pull request #4270: skip the inverted index generation

[GitBox <gi...@apache.org>]

jasperjiaguo commented on a change in pull request #4270: skip the inverted index generation
URL: https://github.com/apache/incubator-pinot/pull/4270#discussion_r291813113
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
 ##########
 @@ -158,7 +158,8 @@ public void init(SegmentGeneratorConfig segmentCreationSpec, SegmentIndexCreatio
         }
 
         // Initialize inverted index creator
-        if (invertedIndexColumns.contains(columnName)) {
+        // Skip creating inverted index if sorted; _invertedIndexCreatorMap is also correctly populated for metadata writing
 
 Review comment:
   Standalone test was performed with pinot-admin commands. No inverted index was generated for sorted columns when I asked the system to do so with generatorConfigFile option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org