You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@knox.apache.org by sm...@apache.org on 2023/07/24 09:52:28 UTC
[knox] branch master updated: KNOX-2944 - Honoring the impalad_specialization role configuration (#781)
This is an automated email from the ASF dual-hosted git repository.
smolnar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/knox.git
The following commit(s) were added to refs/heads/master by this push:
new 8294730b4 KNOX-2944 - Honoring the impalad_specialization role configuration (#781)
8294730b4 is described below
commit 8294730b4c967e0760914a6ac01945c8974beae7
Author: Sandor Molnar <sm...@apache.org>
AuthorDate: Mon Jul 24 11:52:23 2023 +0200
KNOX-2944 - Honoring the impalad_specialization role configuration (#781)
---
.../topology/discovery/cm/model/impala/ImpalaServiceModelGenerator.java | 1 +
.../discovery/cm/model/impala/ImpalaServiceModelGeneratorTest.java | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGenerator.java b/gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGenerator.java
index 78118b5b1..6c2e7b139 100644
--- a/gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGenerator.java
+++ b/gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGenerator.java
@@ -100,6 +100,7 @@ public class ImpalaServiceModelGenerator extends AbstractServiceModelGenerator {
ServiceModel model = createServiceModel(String.format(Locale.getDefault(), "%s://%s:%s/", scheme, hostname, port));
model.addServiceProperty(SSL_ENABLED, getServiceConfigValue(serviceConfig, SSL_ENABLED));
model.addRoleProperty(getRoleType(), HTTP_PORT, port);
+ model.addRoleProperty(getRoleType(), SPECIALIZATION, getRoleConfigValue(roleConfig, SPECIALIZATION));
return model;
}
diff --git a/gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGeneratorTest.java b/gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGeneratorTest.java
index 7777cf81f..9d2c8977d 100644
--- a/gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGeneratorTest.java
+++ b/gateway-discovery-cm/src/test/java/org/apache/knox/gateway/topology/discovery/cm/model/impala/ImpalaServiceModelGeneratorTest.java
@@ -36,7 +36,7 @@ public class ImpalaServiceModelGeneratorTest extends AbstractServiceModelGenerat
final Map<String, String> roleConfig = new HashMap<>();
roleConfig.put(ImpalaServiceModelGenerator.HTTP_PORT, "1357");
- validateServiceModel(createServiceModel(serviceConfig, roleConfig), serviceConfig, roleConfig);
+ validateServiceModel(createServiceModel(serviceConfig, roleConfig), serviceConfig, roleConfig, false);
}
@Override