You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/05/04 05:37:16 UTC
[GitHub] [submarine] jeff-901 opened a new pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
jeff-901 opened a new pull request #579:
URL: https://github.com/apache/submarine/pull/579
### What is this PR for?
Add mock test to new pysubmarine feature -- model management.
### What type of PR is it?
Improvement
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-813
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jojochuang commented on a change in pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #579:
URL: https://github.com/apache/submarine/pull/579#discussion_r625521056
##########
File path: submarine-sdk/pysubmarine/tests/models/test_model.py
##########
@@ -25,7 +27,7 @@
# Temporarily skip these tests after the following is solved:
# TODO: Setup cluster by helm in CI/CD to enable mlflow server connection
# TODO: Set an cooldown time between each test case
-@pytest.mark.skip(reason="no way of currently testing this")
+# @pytest.mark.skip(reason="no way of currently testing this")
Review comment:
If this annotation no longer applies, please remove it entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #579:
URL: https://github.com/apache/submarine/pull/579#discussion_r628750619
##########
File path: submarine-sdk/pysubmarine/tests/models/test_model.py
##########
@@ -15,17 +15,19 @@
under the License.
"""
+import mlflow
import numpy as np
import pytest
+from mlflow.tracking import MlflowClient
from pytorch import LinearNNModel
from submarine import ModelsClient
-
# Temporarily skip these tests after the following is solved:
Review comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on a change in pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on a change in pull request #579:
URL: https://github.com/apache/submarine/pull/579#discussion_r627933335
##########
File path: submarine-sdk/pysubmarine/tests/models/test_model.py
##########
@@ -15,17 +15,19 @@
under the License.
"""
+import mlflow
import numpy as np
import pytest
+from mlflow.tracking import MlflowClient
from pytorch import LinearNNModel
from submarine import ModelsClient
-
# Temporarily skip these tests after the following is solved:
Review comment:
These three lines can be removed too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] kobe860219 merged pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
kobe860219 merged pull request #579:
URL: https://github.com/apache/submarine/pull/579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] ByronHsu commented on pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
ByronHsu commented on pull request #579:
URL: https://github.com/apache/submarine/pull/579#issuecomment-835836496
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] jeff-901 commented on a change in pull request #579: SUBMARINE-813. Add mock test to pysubmarine models.
Posted by GitBox <gi...@apache.org>.
jeff-901 commented on a change in pull request #579:
URL: https://github.com/apache/submarine/pull/579#discussion_r625533543
##########
File path: submarine-sdk/pysubmarine/tests/models/test_model.py
##########
@@ -25,7 +27,7 @@
# Temporarily skip these tests after the following is solved:
# TODO: Setup cluster by helm in CI/CD to enable mlflow server connection
# TODO: Set an cooldown time between each test case
-@pytest.mark.skip(reason="no way of currently testing this")
+# @pytest.mark.skip(reason="no way of currently testing this")
Review comment:
ok. I remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org