You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "beyond1920 (via GitHub)" <gi...@apache.org> on 2023/09/04 12:15:08 UTC

[GitHub] [hudi] beyond1920 commented on a diff in pull request #9594: [HUDI-6742] Remove the log file appending for multiple instants

beyond1920 commented on code in PR #9594:
URL: https://github.com/apache/hudi/pull/9594#discussion_r1313771543


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java:
##########
@@ -87,40 +86,14 @@ public long getSizeThreshold() {
    * Lazily opens the output stream if needed for writing.
    * @return OutputStream for writing to current log file.
    * @throws IOException
-   * @throws InterruptedException
    */
-  private FSDataOutputStream getOutputStream() throws IOException, InterruptedException {
+  private FSDataOutputStream getOutputStream() throws IOException {
     if (this.output == null) {
       Path path = logFile.getPath();
       if (fs.exists(path)) {
-        boolean isAppendSupported = StorageSchemes.isAppendSupported(fs.getScheme());
-        if (isAppendSupported) {
-          LOG.info(logFile + " exists. Appending to existing file");
-          try {
-            // open the path for append and record the offset
-            this.output = fs.append(path, bufferSize);
-          } catch (RemoteException e) {
-            LOG.warn("Remote Exception, attempting to handle or recover lease", e);
-            handleAppendExceptionOrRecoverLease(path, e);

Review Comment:
   `handleAppendExceptionOrRecoverLease` method could be removed now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org