[GitHub] [netbeans] vieiro commented on pull request #5317: code cleanup - no logic changes

["vieiro (via GitHub)" <gi...@apache.org>]

vieiro commented on PR #5317:
URL: https://github.com/apache/netbeans/pull/5317#issuecomment-1407395175

   > @viero - tests are weak, but you gyus cosider writing tests for already existing code a noise :\
   
   On the contrary! I may understand people getting concerned if you _modify_ existing testing code, but _adding_ new tests for existing code is always welcome. Do you want to take a go at writing tests for this module in another PR? This may help us verifying this module works as expected and no subtle new bugs are introduced.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists