[jira] [Commented] (PDFBOX-821) RandomAccessBuffer returns wrong values for single byte reads, patch attached

["Andreas Lehmkühler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027465#comment-13027465 ] 

Andreas Lehmkühler commented on PDFBOX-821:
-------------------------------------------

In revision 1098350 I fixed an issue introduced in the last revision.

Thanks to Kevin Jackson for the hint!

> RandomAccessBuffer returns wrong values for single byte reads, patch attached
> -----------------------------------------------------------------------------
>
>                 Key: PDFBOX-821
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-821
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Parsing
>    Affects Versions: 1.3.1
>            Reporter: Timo Boehme
>            Assignee: Andreas Lehmkühler
>             Fix For: 1.6.0
>
>         Attachments: pdfbox_issue821.patch
>
>
> RandomAccessBuffer contains a critical bug which had no effect so far since this class is currently not used. The problem is in method read() (single byte read). If the byte read is larger than 127 the method returns the signed byte value instead of the unsigned values 128-255. Thus a component using this method will assume end-of-stream.
> The solution is to 'AND' the value with 0xff. Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira