You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "DanTm99 (via GitHub)" <gi...@apache.org> on 2023/02/01 14:43:11 UTC
[GitHub] [arrow] DanTm99 opened a new pull request, #33978: GH-33970: [C#] Make schema field names case sensitive
DanTm99 opened a new pull request, #33978:
URL: https://github.com/apache/arrow/pull/33978
Remove the use of a comparer that ignores casing when building the fields dictionary for a schema.
This allows for fields with names that differ only in casing.
Currently, fields with names that only differ in casing will be seen as having the same name and will cause an Exception to be thrown due to being seen as having duplicate keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "eerhardt (via GitHub)" <gi...@apache.org>.
eerhardt commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1416079758
Thanks for the contribution, @DanTm99! The code change looks good.
Any chance you could write a quick unit test or two for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "eerhardt (via GitHub)" <gi...@apache.org>.
eerhardt commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1416103941
> It's odd to me that a dictionary is used at all. For example, it seems this will still prevent correct loading of tables that have duplicate column names
How do duplicate column names work? If you look it up by name, you get the last one? But each gets an index?
So if I had 2 columns named "Foo", the Count would be `2`, and index 0 would be the first column. Index 1 would be the second column. And if I said `schema.GetFieldByName("Foo")` I'd get the 2nd column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] DanTm99 commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "DanTm99 (via GitHub)" <gi...@apache.org>.
DanTm99 commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1422882399
@westonpace @eerhardt I've created issue #34076 regarding the exception being thrown when multiple fields have the same name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] DanTm99 commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "DanTm99 (via GitHub)" <gi...@apache.org>.
DanTm99 commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1419094288
@eerhardt I've added a few unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1416377940
> How do duplicate column names work? If you look it up by name, you get the last one? But each gets an index?
Yes, each column gets an index and index-lookups always work. In pyarrow a name lookup raises an error if there are duplicate columns. In arrow-rs it appears it always picks the first one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] eerhardt merged pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "eerhardt (via GitHub)" <gi...@apache.org>.
eerhardt merged PR #33978:
URL: https://github.com/apache/arrow/pull/33978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33978: GH-33970: [C#] Make schema field names case sensitive
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #33978:
URL: https://github.com/apache/arrow/pull/33978#issuecomment-1420164543
Benchmark runs are scheduled for baseline = f6bb03e391bc9d3ee627b405aa36da3cfc9b7abb and contender = 9e7b79b37b7db75be7934d59bfdc5e86f21362e8. 9e7b79b37b7db75be7934d59bfdc5e86f21362e8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c94459e8178a4a708d1d69a5c6219a5b...07def7c793da46f59c075a856cb18a32/)
[Failed :arrow_down:0.21% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3eecee7231c9434a9d8ca3393710abbf...5e95ba55c9c34a599fa3824fed4dfd8a/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fbbcb8f2f7e84ff7a8321c998e452903...376a617abd7e438b903a4e04e2518e12/)
[Finished :arrow_down:0.16% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ebe08bb9f8074258969530719a64e0f3...24324fb6c4f34bd8aeb21869e60587cd/)
Buildkite builds:
[Finished] [`9e7b79b3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2334)
[Finished] [`9e7b79b3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2362)
[Finished] [`9e7b79b3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2332)
[Finished] [`9e7b79b3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2353)
[Finished] [`f6bb03e3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2333)
[Failed] [`f6bb03e3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2361)
[Finished] [`f6bb03e3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2331)
[Finished] [`f6bb03e3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2352)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org