[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #10514: Fix the preoblem when using select into with view path which is same as base path.

["JackieTien97 (via GitHub)" <gi...@apache.org>]

JackieTien97 commented on code in PR #10514:
URL: https://github.com/apache/iotdb/pull/10514#discussion_r1260676827


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/IntoOperator.java:
##########
@@ -42,6 +44,8 @@ public class IntoOperator extends AbstractIntoOperator {
 
   private final List<Pair<String, PartialPath>> sourceTargetPathPairList;
 
+  private final List<Pair<String, String>> sourceColumnToViewList;

Review Comment:
   It seems that `List<String> sourceColumnToViewList` is enough.



##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/parameter/IntoPathDescriptor.java:
##########
@@ -47,6 +49,9 @@ public class IntoPathDescriptor {
   // List<(sourceColumn, targetPath)>
   private List<Pair<String, PartialPath>> sourceTargetPathPairList;
 
+  // sourceColumn -> viewPath, if the viewPath is not empty
+  private List<Pair<String, String>> sourceColumnToViewList;

Review Comment:
   It seems that `List<String> sourceColumnToViewList` is enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org