You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@isis.apache.org by Erik de Hair <e....@pocos.nl> on 2016/03/14 09:17:32 UTC

Writing audit entries after action/transaction complete?

Hi,

It looks like the audit logging is executed before an action is fully 
completed. (Is that correct?) Is it possible to do the audit logging 
asynchronously, so after the action itself was fully completed and all 
changes committed to the database? For larger data structures the audit 
logging takes a relatively large amount of time because of all the 
separate inserts per property.

This way we missed some asynchronously sent response messages from our 
suppliers. We should fix this in a different way, but I thought it might 
be something that could improve responsiveness of the application.

Met vriendelijke groet,


*Erik de Hair*

Software Engineer | Pocos bv

Pocos gaat verhuizen! Vanaf 29 maart is ons adres: Beemdstraat 1b, 5653 
MA Eindhoven.

Pocos bv Telecom Inspirience awards - Best VaMo Project

T: 088-0100713 <tel:088-0100713> | e.dehair@pocos.nl 
<ma...@pocos.nl> | Partner ondersteuning: partner@pocos.nl 
<ma...@pocos.nl> | Service: servicedesk@pocos.nl 
<ma...@pocos.nl>

www.pocos.nl <http://www.pocos.nl/> | Croy 9c, 5653 LC Eindhoven | Kamer 
van Koophandel 17097024 | btn_in_20x15 
<https://www.linkedin.com/company/pocos?trk=prof-following-company-logo> 
twitter <https://twitter.com/Pocosbv>



Re: Writing audit entries after action/transaction complete?

Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Sure. Actually, ActiveMQ is pretty easy to set configure, and the
implementation to publish to a queue even easier...

https://github.com/isisaddons/isis-module-publishmq/blob/master/webapp/src/main/webapp/WEB-INF/web.xml#L27
https://github.com/isisaddons/isis-module-publishmq/blob/master/webapp/src/main/webapp/WEB-INF/web.xml#L34
https://github.com/isisaddons/isis-module-publishmq/blob/master/webapp/src/main/resources/activemq-config.xml
https://github.com/isisaddons/isis-module-publishmq/blob/master/webapp/pom.xml#L369

https://github.com/isisaddons/isis-module-publishmq/blob/master/dom/servicespi/src/main/java/org/isisaddons/module/publishmq/dom/servicespi/PublishingServiceUsingActiveMq.java#L153




On 15 Mar 2016 11:27 am, "Erik de Hair" <e....@pocos.nl> wrote:

> Hi Dan,
>
> Thanks, I will look at how that addon works to write our own
> implementation. Implementing Activemq is a bit to much effort for a small
> improvement but it could be interesting in the future.
>
> Met vriendelijke groet,
>
>
> *Erik de Hair*
>
> Software Engineer | Pocos bv
>
>
> On 03/14/2016 10:30 AM, Dan Haywood wrote:
>
>>
>> Hi Erik,
>>
>> yes, the framework calls the auditing service within the transaction.
>>
>> The implementation of the auditing service is pluggable however, and in
>> fact the framework did not itself provide an out-of-the-box implementation.
>> I presume you are therefore referring to the Isis Addons implementation,
>> which behaves as you say.
>>
>> But it is very easy to provide your own implementation.  That could use
>> Activemq, for example, to decouple the persisting of the audit records from
>> the original request. I mention Activemq because there is the publisher in
>> Isis Add-ons for the rather similar publishing service SPI
>>
>> Hope that helps
>> Dan
>>
>> On 14 Mar 2016 08:20, "Erik de Hair" <e.dehair@pocos.nl <mailto:
>> e.dehair@pocos.nl>> wrote:
>>
>>     Hi,
>>
>>     It looks like the audit logging is executed before an action is
>>     fully completed. (Is that correct?) Is it possible to do the audit
>>     logging asynchronously, so after the action itself was fully
>>     completed and all changes committed to the database? For larger
>>     data structures the audit logging takes a relatively large amount
>>     of time because of all the separate inserts per property.
>>
>>     This way we missed some asynchronously sent response messages from
>>     our suppliers. We should fix this in a different way, but I
>>     thought it might be something that could improve responsiveness of
>>     the application.
>>
>>     Met vriendelijke groet,
>>
>>
>>     *Erik de Hair*
>>
>>     Software Engineer | Pocos bv
>>
>>     Pocos gaat verhuizen! Vanaf 29 maart is ons adres: Beemdstraat 1b,
>>     5653 MA Eindhoven.
>>
>>     Pocos bv Telecom Inspirience awards - Best VaMo Project
>>
>>     T: 088-0100713 <tel:088-0100713> | e.dehair@pocos.nl
>>     <ma...@pocos.nl> | Partner ondersteuning:
>>     partner@pocos.nl <ma...@pocos.nl> | Service:
>>     servicedesk@pocos.nl <ma...@pocos.nl>
>>
>>     www.pocos.nl <http://www.pocos.nl/> | Croy 9c, 5653 LC Eindhoven |
>>     Kamer van Koophandel 17097024 | btn_in_20x15
>>     <
>> https://www.linkedin.com/company/pocos?trk=prof-following-company-logo>
>>     twitter <https://twitter.com/Pocosbv>
>>
>>
>>
>

Re: Writing audit entries after action/transaction complete?

Posted by Erik de Hair <e....@pocos.nl>.
Hi Dan,

Thanks, I will look at how that addon works to write our own 
implementation. Implementing Activemq is a bit to much effort for a 
small improvement but it could be interesting in the future.

Met vriendelijke groet,


*Erik de Hair*

Software Engineer | Pocos bv


On 03/14/2016 10:30 AM, Dan Haywood wrote:
>
> Hi Erik,
>
> yes, the framework calls the auditing service within the transaction.
>
> The implementation of the auditing service is pluggable however, and 
> in fact the framework did not itself provide an out-of-the-box 
> implementation. I presume you are therefore referring to the Isis 
> Addons implementation, which behaves as you say.
>
> But it is very easy to provide your own implementation.  That could 
> use Activemq, for example, to decouple the persisting of the audit 
> records from the original request. I mention Activemq because there is 
> the publisher in Isis Add-ons for the rather similar publishing 
> service SPI
>
> Hope that helps
> Dan
>
> On 14 Mar 2016 08:20, "Erik de Hair" <e.dehair@pocos.nl 
> <ma...@pocos.nl>> wrote:
>
>     Hi,
>
>     It looks like the audit logging is executed before an action is
>     fully completed. (Is that correct?) Is it possible to do the audit
>     logging asynchronously, so after the action itself was fully
>     completed and all changes committed to the database? For larger
>     data structures the audit logging takes a relatively large amount
>     of time because of all the separate inserts per property.
>
>     This way we missed some asynchronously sent response messages from
>     our suppliers. We should fix this in a different way, but I
>     thought it might be something that could improve responsiveness of
>     the application.
>
>     Met vriendelijke groet,
>
>
>     *Erik de Hair*
>
>     Software Engineer | Pocos bv
>
>     Pocos gaat verhuizen! Vanaf 29 maart is ons adres: Beemdstraat 1b,
>     5653 MA Eindhoven.
>
>     Pocos bv Telecom Inspirience awards - Best VaMo Project
>
>     T: 088-0100713 <tel:088-0100713> | e.dehair@pocos.nl
>     <ma...@pocos.nl> | Partner ondersteuning:
>     partner@pocos.nl <ma...@pocos.nl> | Service:
>     servicedesk@pocos.nl <ma...@pocos.nl>
>
>     www.pocos.nl <http://www.pocos.nl/> | Croy 9c, 5653 LC Eindhoven |
>     Kamer van Koophandel 17097024 | btn_in_20x15
>     <https://www.linkedin.com/company/pocos?trk=prof-following-company-logo>
>     twitter <https://twitter.com/Pocosbv>
>
>


Re: Writing audit entries after action/transaction complete?

Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Hi Erik,

yes, the framework calls the auditing service within the transaction.

The implementation of the auditing service is pluggable however, and in
fact the framework did not itself provide an out-of-the-box implementation.
I presume you are therefore referring to the Isis Addons implementation,
which behaves as you say.

But it is very easy to provide your own implementation.  That could use
Activemq, for example, to decouple the persisting of the audit records from
the original request. I mention Activemq because there is the publisher in
Isis Add-ons for the rather similar publishing service SPI

Hope that helps
Dan
On 14 Mar 2016 08:20, "Erik de Hair" <e....@pocos.nl> wrote:

> Hi,
>
> It looks like the audit logging is executed before an action is fully
> completed. (Is that correct?) Is it possible to do the audit logging
> asynchronously, so after the action itself was fully completed and all
> changes committed to the database? For larger data structures the audit
> logging takes a relatively large amount of time because of all the separate
> inserts per property.
>
> This way we missed some asynchronously sent response messages from our
> suppliers. We should fix this in a different way, but I thought it might be
> something that could improve responsiveness of the application.
>
> Met vriendelijke groet,
>
>
> *Erik de Hair*
>
> Software Engineer | Pocos bv
>
> Pocos gaat verhuizen! Vanaf 29 maart is ons adres: Beemdstraat 1b, 5653 MA
> Eindhoven.
>
> [image: Pocos bv] [image: Telecom Inspirience awards - Best VaMo Project]
>
> T: 088-0100713 | e.dehair@pocos.nl | Partner ondersteuning:
> partner@pocos.nl <sa...@pocos.nl> | Service: servicedesk@pocos.nl
>
> www.pocos.nl | Croy 9c, 5653 LC Eindhoven | Kamer van Koophandel 17097024
> | [image: btn_in_20x15]
> <https://www.linkedin.com/company/pocos?trk=prof-following-company-logo> [image:
> twitter] <https://twitter.com/Pocosbv>
>
>