You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2013/10/30 18:24:06 UTC

svn commit: r1537189 - /spamassassin/trunk/t/dnsbl_subtests.t

Author: mmartinec
Date: Wed Oct 30 17:24:05 2013
New Revision: 1537189

URL: http://svn.apache.org/r1537189
Log:
Bug 6983: Uninitialized value in lc in t/dnsbl_subtests - perl bug, fixed in 5.8.9

Modified:
    spamassassin/trunk/t/dnsbl_subtests.t

Modified: spamassassin/trunk/t/dnsbl_subtests.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/t/dnsbl_subtests.t?rev=1537189&r1=1537188&r2=1537189&view=diff
==============================================================================
--- spamassassin/trunk/t/dnsbl_subtests.t (original)
+++ spamassassin/trunk/t/dnsbl_subtests.t Wed Oct 30 17:24:05 2013
@@ -49,7 +49,7 @@ printf("Using %s [%s]:%s for a spawned t
        $use_inet4 ? 'inet' : 'inet6',
        $dns_server_localaddr, $dns_server_localport);
 
-# test zones
+# test zone names (lowercase!)
 my $z  = 'sa1-dbl-test.spamassassin.org';
 my $z2 = 'sa2-dbl-test.spamassassin.org';
 
@@ -207,7 +207,10 @@ sub reply_handler {
     }
   }
   # special DBL test case - numerical IP query handling
-  if ($qclass_uc eq 'IN' && $qname =~ /^[0-9.]+\.(?:\Q$z\E|\Q$z2\E)\z/is) {
+    # Bug 6983: Uninitialized value in lc in t/dnsbl_subtests for X_URIBL_Y_255A
+    # Unicode case folding bug present in at least perl-5.8.[678], fixed 5.8.9
+    # avoid case-insensitive regexp match, $z and $z2 are already in lowercase
+  if ($qclass_uc eq 'IN' && lc $qname =~ /^[0-9.]+\.(?:\Q$z\E|\Q$z2\E)\z/s) {
     $rcode = 'NOERROR';
     if ($qtype_uc eq 'A' || $qtype_uc eq 'ANY') {
       push(@ans, Net::DNS::RR->new(join(' ',