You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by jr...@apache.org on 2009/04/04 19:43:52 UTC

svn commit: r761975 - /wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java

Author: jrthomerson
Date: Sat Apr  4 17:43:52 2009
New Revision: 761975

URL: http://svn.apache.org/viewvc?rev=761975&view=rev
Log:
WICKET-670
debug bar - allow a contributor that does not contribute a component.


Modified:
    wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java

Modified: wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java?rev=761975&r1=761974&r2=761975&view=diff
==============================================================================
--- wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java (original)
+++ wicket/trunk/wicket-devutils/src/main/java/org/apache/wicket/devutils/debugbar/DebugBar.java Sat Apr  4 17:43:52 2009
@@ -21,6 +21,7 @@
 
 import org.apache.wicket.Application;
 import org.apache.wicket.AttributeModifier;
+import org.apache.wicket.Component;
 import org.apache.wicket.MetaDataKey;
 import org.apache.wicket.ResourceReference;
 import org.apache.wicket.devutils.DevUtilsPanel;
@@ -104,8 +105,15 @@
 
 			@Override
 			protected void populateItem(ListItem<IDebugBarContributor> item) {
-				item.add(item.getModelObject().createComponent("contrib",
-						DebugBar.this));
+				IDebugBarContributor contrib = item.getModelObject();
+				Component comp = contrib.createComponent("contrib", DebugBar.this);
+				if (comp == null) {
+					// some contributors only add information to the debug bar
+					//	and don't actually create a contributed component
+					item.setVisibilityAllowed(false);
+				} else {
+					item.add(comp);
+				}
 			}
 		});
 	}