You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Mike Tillberg (JIRA)" <ji...@apache.org> on 2007/08/25 18:45:30 UTC
[jira] Created: (SCXML-54) Events from custom actions missing
payload
Events from custom actions missing payload
------------------------------------------
Key: SCXML-54
URL: https://issues.apache.org/jira/browse/SCXML-54
Project: Commons SCXML
Issue Type: Bug
Affects Versions: 0.7
Environment: 20070730 nightly build
Reporter: Mike Tillberg
Priority: Minor
I'm trying to generate events from custom events by adding
TriggerEvent objects into the derivedEvents argument. This is working
in terms of triggering transitions, however I'm unable to properly
access the payload from these generated events, depending on the
evaluator being used. With the EL evaluator, _eventdata and
_eventdatamap seem to be empty when the transition fires. With JEXL,
the payload is available, however the assignments seem to be in a local
context, even though the variable I'm assigning should only exist in the
root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SCXML-54) Events from custom actions missing
payload
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar resolved SCXML-54.
--------------------------------
Resolution: Fixed
Fixed in SVN, thanks for the test cases. I've added your name to the project contributors section.
One caveat -- for derived events, Commons SCXML introduces _eventdatamap (since there are usually more than one derived events). Therefore, _eventdata in the test cases attached here needs to change to _eventdatamap.helloevent or _eventdatamap['helloevent'] (alternative syntax for event names that have the dot character in them).
See this modified test case as an example (long, possibly fragmented URL below):
http://svn.apache.org/viewvc/commons/proper/scxml/trunk/src/test/java/org/apache/commons/scxml/custom-hello-world-04-jexl.xml?view=markup
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.6
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Fix For: 0.7
>
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-54) Events from custom actions missing
payload
Posted by "Mike Tillberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524281 ]
Mike Tillberg commented on SCXML-54:
------------------------------------
ICLA signed and submitted via fax.
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.6
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Fix For: 0.7
>
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-54) Events from custom actions missing
payload
Posted by "Mike Tillberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Tillberg updated SCXML-54:
-------------------------------
Attachment: SCXMLTestHelper.patch
This fixes a small, potential issue I found while examining this problem. The SCXMLTestHelper generates JexlContexts directly, rather than calling evaluator.newContext(null). This doesn't have any effect on the tests, including the EL one I attached, but this would seem to be the safer way to create contexts.
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.7
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-54) Events from custom actions missing
payload
Posted by "Mike Tillberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Tillberg updated SCXML-54:
-------------------------------
Attachment: HelloEvent.java
custom-hello-world-04-jexl.xml
custom-hello-world-04-el.xml
EL and JEXL versions of a simple state machine for testing custom action event generation. The HelloEvent class is a modified version of the existing Hello.java that generates an event and places it into the derivedEvents collection.
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.7
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-54) Events from custom actions missing
payload
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523633 ]
Rahul Akolkar commented on SCXML-54:
------------------------------------
Thanks for the patch(es) Mike. I am traveling this till Sep 5th, I intend to look at this when am back.
In the meantime, could you also fill out an Individual Contributor License Agreement (ICLA)? That is here (the fax number is on the form itself, you can mail it in too if you want):
http://www.apache.org/licenses/icla.txt
This a one-time thing, and is needed for contributions such as this one which may contain new source files, for provenance and pedigree reasons. Let us know if you have any questions about the ICLA. Do ping this issue when you send it in and we can track its receipt. Thanks.
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.7
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-54) Events from custom actions missing
payload
Posted by "Mike Tillberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Tillberg updated SCXML-54:
-------------------------------
Attachment: CustomActionTest.java
Modified CustomActionTest class for running the additional test cases.
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.7
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SCXML-54) Events from custom actions missing
payload
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rahul Akolkar updated SCXML-54:
-------------------------------
Fix Version/s: 0.7
Affects Version/s: (was: 0.7)
0.6
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.6
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Fix For: 0.7
>
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SCXML-54) Events from custom actions missing
payload
Posted by "Rahul Akolkar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SCXML-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12524398 ]
Rahul Akolkar commented on SCXML-54:
------------------------------------
Great, I'll track its receipt (usually, a few days to being recorded).
> Events from custom actions missing payload
> ------------------------------------------
>
> Key: SCXML-54
> URL: https://issues.apache.org/jira/browse/SCXML-54
> Project: Commons SCXML
> Issue Type: Bug
> Affects Versions: 0.6
> Environment: 20070730 nightly build
> Reporter: Mike Tillberg
> Priority: Minor
> Fix For: 0.7
>
> Attachments: custom-hello-world-04-el.xml, custom-hello-world-04-jexl.xml, CustomActionTest.java, HelloEvent.java, SCXMLTestHelper.patch
>
>
> I'm trying to generate events from custom events by adding
> TriggerEvent objects into the derivedEvents argument. This is working
> in terms of triggering transitions, however I'm unable to properly
> access the payload from these generated events, depending on the
> evaluator being used. With the EL evaluator, _eventdata and
> _eventdatamap seem to be empty when the transition fires. With JEXL,
> the payload is available, however the assignments seem to be in a local
> context, even though the variable I'm assigning should only exist in the
> root context.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.