You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/11/08 20:06:20 UTC
Review Request 27778: Fix false positive client test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27778/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Repository: aurora
Description
-------
This test case passes despite encountering an `AttributeError`. I've fixed the error, but there's a much broader effort needed to make sure tests fail when errors like this are encountered.
Diffs
-----
src/test/python/apache/aurora/client/cli/test_kill.py 78f5f04507d7fe080a1ed5ddda692e52f66cc18d
Diff: https://reviews.apache.org/r/27778/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 27778: Fix false positive client test.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27778/#review60491
-----------------------------------------------------------
Master (54b0262) is red with this patch.
./build-support/jenkins/build.sh
new_config = deepcopy(old_configs[0])
new_config.priority = 5
job_config = self.make_job_config(new_config, 5)
self._config.job_config = job_config
self.expect_start()
self.expect_get_tasks(old_configs)
self.expect_populate(job_config)
self.expect_quota_check(5, 5)
self.expect_update_instances([0, 1, 2, 3, 4], new_config)
self.expect_finish()
self.replay_mocks()
> self.update_and_expect_ok()
src/test/python/apache/aurora/client/api/test_updater.py:909:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/client/api/test_updater.py:344: in update_and_expect_ok
self.update_and_expect_response(ResponseCode.OK, instances)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <client.api.test_updater.UpdaterTest testMethod=test_update_instances_wait_for_batch_completion_partially_filled_batch>
expected_code = 1, instances = None, message = None
def update_and_expect_response(self, expected_code, instances=None, message=None):
resp = self._updater.update(instances)
> assert expected_code == resp.responseCode, (
'Expected response:%s Actual response:%s' % (expected_code, resp.responseCode))
E AssertionError: Expected response:1 Actual response:2
E assert 1 == 2
E + where 2 = Response(DEPRECATEDversion=None, messageDEPRECATED='Aborting update without ro...minate() -> None\n+ <UnorderedGroup "default">')], responseCode=2, result=None).responseCode
src/test/python/apache/aurora/client/api/test_updater.py:348: AssertionError
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.client.api.updater.xml
!!!!!!!!!!!!!!!!!!!! Interrupted: stopping after 1 failures !!!!!!!!!!!!!!!!!!!!
===================== 1 failed, 24 passed in 0.93 seconds ======================
Build operating on top level addresses: set([BuildFileAddress(/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/BUILD, all)])
src.test.python.apache.aurora.admin.admin_util ..... SUCCESS
src.test.python.apache.aurora.admin.host_maintenance ..... SUCCESS
src.test.python.apache.aurora.client.api.api ..... SUCCESS
src.test.python.apache.aurora.client.api.disambiguator ..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher ..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor ..... SUCCESS
src.test.python.apache.aurora.client.api.mux ..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check ..... SUCCESS
src.test.python.apache.aurora.client.api.restarter ..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client ..... SUCCESS
src.test.python.apache.aurora.client.api.sla ..... SUCCESS
src.test.python.apache.aurora.client.api.updater ..... FAILURE
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
- Aurora ReviewBot
On Nov. 8, 2014, 7:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27778/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2014, 7:06 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This test case passes despite encountering an `AttributeError`. I've fixed the error, but there's a much broader effort needed to make sure tests fail when errors like this are encountered.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/client/cli/test_kill.py 78f5f04507d7fe080a1ed5ddda692e52f66cc18d
>
> Diff: https://reviews.apache.org/r/27778/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>