[GitHub] [ignite-3] valepakh commented on a diff in pull request #1033: IGNITE-17527 Add short aliases for options

[GitBox <gi...@apache.org>]

valepakh commented on code in PR #1033:
URL: https://github.com/apache/ignite-3/pull/1033#discussion_r963735147


##########
modules/cli/src/main/java/org/apache/ignite/cli/commands/connect/ConnectCommand.java:
##########
@@ -44,7 +46,7 @@ public class ConnectCommand extends BaseCommand implements Runnable {
     @Override
     public void run() {
         CallExecutionPipeline.builder(connectCall)
-                .inputProvider(() -> new ConnectCallInput(nodeUrl))
+                .inputProvider(() -> new ConnectCallInput(nodeUrl.toString()))

Review Comment:
   In this command `nodeUrl` is a parameter, not an option, and it can't be null - it will taken from either the parameter or from the config via the `descriptionKey`, and will throw an error in case the config doesn't have this parameter defined.
   I added a test which shows that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org