[GitHub] [arrow] ianmcook commented on a change in pull request #9205: ARROW-11253 [R]: Make sure that large metadata tests are reproducible

[GitBox <gi...@apache.org>]

ianmcook commented on a change in pull request #9205:
URL: https://github.com/apache/arrow/pull/9205#discussion_r557718717



##########
File path: r/tests/testthat/helper-data.R
##########
@@ -68,9 +68,13 @@ make_big_string <- function() {
   rep(purrr::map_chr(2047:2050, ~paste(sample(letters, ., replace = TRUE), collapse = "")), 2^18)
 }
 
-make_string_of_size <- function(size = 1) {
+make_random_string_of_size <- function(size = 1) {
   purrr::map_chr(1000*size, ~paste(sample(letters, ., replace = TRUE), collapse = ""))
 }
 
+make_string_of_size <- function(size = 1) {
+  purrr::map_chr(1000*size, ~paste(rep(letters, length = .), collapse = ""))

Review comment:
       It's not immediately clear to me why this can't just be:
   ```r
   paste(rep(letters, length = 1000*size), collapse = "")
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org