You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by pk...@apache.org on 2022/11/20 13:35:14 UTC

[incubator-nuttx] 22/26: Fix error: shifting a negative signed value is undefined

This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit ffda739704c51e4082350552a8661163b4ab70fe
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Sat Nov 19 13:15:54 2022 +0800

    Fix error: shifting a negative signed value is undefined
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c  | 4 ++--
 boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c b/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c
index 6a385dcf0c..b7277383d0 100644
--- a/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c
+++ b/boards/arm/stm32/fire-stm32v2/src/stm32_selectlcd.c
@@ -163,8 +163,8 @@ void stm32_selectlcd(void)
 
   /* Bank1 NOR/SRAM timing register configuration */
 
-  putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(0) |
-           FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(0) |
+  putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(1) |
+           FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(1) |
            FSMC_BTR_CLKDIV(1) | FSMC_BTR_DATLAT(2) |
            FSMC_BTR_ACCMODA, STM32_FSMC_BTR1);
 
diff --git a/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c b/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c
index ad62481973..2214ef3850 100644
--- a/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c
+++ b/boards/arm/stm32/stm3210e-eval/src/stm32_selectlcd.c
@@ -115,8 +115,8 @@ void stm32_selectlcd(void)
 
   /* Bank4 NOR/SRAM timing register configuration */
 
-  putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(0) |
-           FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(0) |
+  putreg32(FSMC_BTR_ADDSET(1) | FSMC_BTR_ADDHLD(1) |
+           FSMC_BTR_DATAST(2) | FSMC_BTR_BUSTURN(1) |
            FSMC_BTR_CLKDIV(1) | FSMC_BTR_DATLAT(2) |
            FSMC_BTR_ACCMODA, STM32_FSMC_BTR4);