You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "bruno-roustant (via GitHub)" <gi...@apache.org> on 2025/02/18 11:28:49 UTC
[PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]
bruno-roustant opened a new pull request, #3194:
URL: https://github.com/apache/solr/pull/3194
https://issues.apache.org/jira/browse/SOLR-17675
In a previous [PR](https://github.com/apache/solr/pull/3185), we noted that the DirContext of the DirectoryFactory.create method should be removed. It was used only by the HdfsDirectoryFactory (now removed), and there was a bug in CachingDirectoryFactory which would create a Directory with this param, and cache it without this param in the cache key.
We already added a todo in DirectoryFactory, and the proposal is to apply this todo: remove the DirContext param from the DirectoryFactory.create method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]
Posted by "bruno-roustant (via GitHub)" <gi...@apache.org>.
bruno-roustant commented on PR #3194:
URL: https://github.com/apache/solr/pull/3194#issuecomment-2665405184
Is this a public API change that should that be only for main 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]
Posted by "bruno-roustant (via GitHub)" <gi...@apache.org>.
bruno-roustant merged PR #3194:
URL: https://github.com/apache/solr/pull/3194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] @SOLR-17675 Remove DirContext param from DirectoryFactory create method. [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #3194:
URL: https://github.com/apache/solr/pull/3194#issuecomment-2666078517
Since HDFS was only removed on main 10, I *think* this refactoring should only go on main as well? 9x will still have HdfsDirectoryFactor. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org