You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/09/05 20:28:58 UTC
Re: Review Request 61925: Utilized 'AuthorizationAcceptor' in agent
endpoint handlers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61925/
-----------------------------------------------------------
(Updated Sept. 5, 2017, 8:28 p.m.)
Review request for mesos and Greg Mann.
Bugs: MESOS-7914
https://issues.apache.org/jira/browse/MESOS-7914
Repository: mesos
Description
-------
This patch updates the agent endpoint handlers to make use of
the `AuthorizationAcceptor` exclusively for authorization,
eliminating the need to explicitly create authorization
subjects and objects.
Endpoint-related slave authorization tests are also updated to
accommodate this change.
Diffs (updated)
-----
src/slave/http.hpp 44a95dec4c9b8bb65d712c5538bbd7afffe2cf7b
src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce
src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a
Diff: https://reviews.apache.org/r/61925/diff/2/
Changes: https://reviews.apache.org/r/61925/diff/1-2/
Testing
-------
`make check`
Thanks,
Greg Mann
Re: Review Request 61925: Utilized 'AuthorizationAcceptor' in agent
endpoint handlers.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61925/#review184605
-----------------------------------------------------------
FAIL: Mesos tests failed to run
Reviews applied: [61922, 61923, 61924, 61925]
Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/61925/logs
- Mesos Reviewbot Windows
On Sept. 5, 2017, 8:28 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61925/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2017, 8:28 p.m.)
>
>
> Review request for mesos and Greg Mann.
>
>
> Bugs: MESOS-7914
> https://issues.apache.org/jira/browse/MESOS-7914
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates the agent endpoint handlers to make use of
> the `AuthorizationAcceptor` exclusively for authorization,
> eliminating the need to explicitly create authorization
> subjects and objects.
>
> Endpoint-related slave authorization tests are also updated to
> accommodate this change.
>
>
> Diffs
> -----
>
> src/slave/http.hpp 44a95dec4c9b8bb65d712c5538bbd7afffe2cf7b
> src/slave/http.cpp 3ea7829df8c1c35d2fa3a44f19a60b7e261042ce
> src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a
>
>
> Diff: https://reviews.apache.org/r/61925/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Greg Mann
>
>