[GitHub] [spark] dchvn commented on a change in pull request #34179: [SPARK-36930][PYTHON] Support ps.MultiIndex.dtypes

[GitBox <gi...@apache.org>]

dchvn commented on a change in pull request #34179:
URL: https://github.com/apache/spark/pull/34179#discussion_r722876518



##########
File path: python/pyspark/pandas/indexes/multi.py
##########
@@ -375,6 +375,13 @@ def name(self) -> Name:
     def name(self, name: Name) -> None:
         raise PandasNotImplementedError(class_name="pd.MultiIndex", property_name="name")
 
+    @property
+    def dtypes(self) -> pd.Series:
+        return pd.Series(
+            [field.dtype for field in self._internal.index_fields],
+            index=[name if len(name) > 1 else name[0] for name in self._internal.index_names],

Review comment:
       thanks, updated

##########
File path: python/pyspark/pandas/indexes/multi.py
##########
@@ -375,6 +375,13 @@ def name(self) -> Name:
     def name(self, name: Name) -> None:
         raise PandasNotImplementedError(class_name="pd.MultiIndex", property_name="name")
 
+    @property
+    def dtypes(self) -> pd.Series:

Review comment:
       updated

##########
File path: python/pyspark/pandas/tests/test_dataframe.py
##########
@@ -6000,6 +6000,13 @@ def test_combine_first(self):
             expected_pdf = pd.DataFrame({"A": [None, 0], "B": [4.0, 1.0], "C": [3, 3]})
             self.assert_eq(expected_pdf, psdf1.combine_first(psdf2))
 
+    def test_multi_index_dtypes(self):

Review comment:
       thanks, updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org