You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by dhatchayani <gi...@git.apache.org> on 2018/05/10 13:38:31 UTC
[GitHub] carbondata pull request #2295: [CARBONDATA-2470] Refactor AlterTableCompacti...
GitHub user dhatchayani opened a pull request:
https://github.com/apache/carbondata/pull/2295
[CARBONDATA-2470] Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow
AlterTableCompactionPostStatusUpdateEvent is a generic event fired after COMPACTION but it is controlled only by the preaggregate listener. If the CommitPreAggregateListener sets the commitComplete property to true, this event will not be fired for the next iteration. For each and every compacted segments this must be fired.
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [x] Testing done
UTs are already there
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhatchayani/carbondata postEvent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2295.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2295
----
commit b350b40643c6355b74c03b047579401fd54acae6
Author: dhatchayani <dh...@...>
Date: 2018-05-10T13:37:53Z
[CARBONDATA-2470] Refactor AlterTableCompactionPostStatusUpdateEvent usage in compaction flow
----
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4960/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4922/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5933/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5943/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4925/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4737/
---
[GitHub] carbondata pull request #2295: [CARBONDATA-2470] Refactor AlterTableCompacti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2295
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5887/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4778/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4732/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4775/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4788/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5891/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2295
LGTM
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5810/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4959/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5930/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/2295
retest this please
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4783/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by dhatchayani <gi...@git.apache.org>.
Github user dhatchayani commented on the issue:
https://github.com/apache/carbondata/pull/2295
Retest this please
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5938/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4969/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2295
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4862/
---
[GitHub] carbondata issue #2295: [CARBONDATA-2470] Refactor AlterTableCompactionPostS...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2295
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4655/
---
[GitHub] carbondata pull request #2295: [CARBONDATA-2470] Refactor AlterTableCompacti...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2295#discussion_r188847413
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala ---
@@ -569,9 +577,8 @@ object CommitPreAggregateListener extends OperationEventListener with CommitHelp
if (commitFailed) {
sys.error("Failed to update table status for pre-aggregate table")
}
- }
-
-
+ operationContext.setProperty("commitComplete", !commitFailed)
--- End diff --
In case of any exception this will not get set and the load would be marked as a success.
---