You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2019/10/25 17:44:10 UTC
[GitHub] [phoenix] kadirozde commented on a change in pull request #605: PHOENIX-5540 Full row index write at the last write phase for immutab…
kadirozde commented on a change in pull request #605: PHOENIX-5540 Full row index write at the last write phase for immutab…
URL: https://github.com/apache/phoenix/pull/605#discussion_r339166371
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/execute/MutationState.java
##########
@@ -1239,15 +1239,17 @@ private void filterIndexCheckerMutations(Map<TableInfo, List<Mutation>> mutation
} else if (m instanceof Put) {
long timestamp = IndexRegionObserver.getMaxTimestamp(m);
- // Phase 1 index mutations are set to unverified
- ((Put) m).addColumn(emptyCF, emptyCQ, timestamp, IndexRegionObserver.UNVERIFIED_BYTES);
- addToMap(unverifiedIndexMutations, tableInfo, m);
+ // Phase 1 index mutations are set to unverified.
+ // Just send empty with Unverified
+ Put unverifiedPut = new Put(m.getRow());
+ unverifiedPut.addColumn(emptyCF, emptyCQ, timestamp, IndexRegionObserver.UNVERIFIED_BYTES);
+ addToMap(unverifiedIndexMutations, tableInfo, unverifiedPut);
// Phase 3 mutations are verified
- Put verifiedPut = new Put(m.getRow());
- verifiedPut.addColumn(emptyCF, emptyCQ, timestamp,
+ // Send entire mutation with verified
+ ((Put) m).addColumn(emptyCF, emptyCQ, timestamp,
Review comment:
The empty column is already part of the mutation at this moment with value "x". Can we remove it first and add the new one as the patch for PHOENIX-5539 does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services