You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 18:57:08 UTC

[GitHub] [airflow] ryanahamilton opened a new pull request #11089: Task Instance header/navigation pattern UX cleanup

ryanahamilton opened a new pull request #11089:
URL: https://github.com/apache/airflow/pull/11089


   Related to #10953 in ongoing efforts to clean up the UI (and prepare for broader design updates).
   
   The current Task Instance View is nested within the DAG view layout, yielding a convoluted header that consists of [two different headers and sets of actions](https://r.hmlt.in/9ZuX5N17). This update removes this nesting in order to prioritize the navigation related to the Task Instance. There is a breadcrumb link above the page title that provides a path back to the parent DAG.
   
   | Before | After |
   |---|---|
   |  ![image](https://user-images.githubusercontent.com/3267/93923722-c15a8e80-fce1-11ea-8a36-faafdb39cff3.png) |  ![image](https://user-images.githubusercontent.com/3267/93923746-c7506f80-fce1-11ea-9e05-99735a7c1d2d.png) |
   
   Additionally, I've applied the same "breadcrumb link" pattern employed above when viewing a SubDAG instead of dynamically jamming a link within the pill menu.
   
   | Before | After |
   |---|---|
   | ![image](https://user-images.githubusercontent.com/3267/93923706-bdc70780-fce1-11ea-86ad-23b25de80b67.png)  | ![image](https://user-images.githubusercontent.com/3267/93923866-f535b400-fce1-11ea-8b92-2aa136afb291.png)  |
   
   
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton closed pull request #11089: Task Instance header/navigation pattern UX cleanup

Posted by GitBox <gi...@apache.org>.
ryanahamilton closed pull request #11089:
URL: https://github.com/apache/airflow/pull/11089


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #11089: Task Instance header/navigation pattern UX cleanup

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11089:
URL: https://github.com/apache/airflow/pull/11089#issuecomment-697380511


   @ryanahamilton I'm using the navigation buttons. In most cases when I use UI, I use it to analyze the DAG, so jumping from single task instance to Gantt and then to some other place is quite common. However, I think it would be best to ask those who use UI more often than me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #11089: Task Instance header/navigation pattern UX cleanup

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11089:
URL: https://github.com/apache/airflow/pull/11089#issuecomment-696942698


   Thanks @ryanahamilton ! I'm personally against removing "dag buttons" from "task instance view" because I'm using them. Not often but they are part of flow where I can simply access any information about TI or DAG.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] turbaszek commented on pull request #11089: Task Instance header/navigation pattern UX cleanup

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #11089:
URL: https://github.com/apache/airflow/pull/11089#issuecomment-696942698


   Thanks @ryanahamilton ! I'm personally against removing "dag buttons" from "task instance view" because I'm using them. Not often but they are part of flow where I can simply access any information about TI or DAG.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on pull request #11089: Task Instance header/navigation pattern UX cleanup

Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #11089:
URL: https://github.com/apache/airflow/pull/11089#issuecomment-697343542


   @turbaszek thank you for the feedback. I'd be interested in hearing more about how you use the buttons. More specifically, do you find yourself triggering, pausing/unpausing, refreshing, or deleting the DAG from this Task Instance view? Of all of the buttons, those are the only "actions" one can take. The rest are navigation links. I'm convinced that this current stacked navigation isn't a great pattern to use. Maybe there's still a way for me to improve this while not interrupting any user flow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org