You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by alpinegizmo <gi...@git.apache.org> on 2017/05/09 15:40:29 UTC
[GitHub] flink pull request #3857: [FLINK-6512][docs] improved code formatting in som...
GitHub user alpinegizmo opened a pull request:
https://github.com/apache/flink/pull/3857
[FLINK-6512][docs] improved code formatting in some examples
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alpinegizmo/flink 6512-code-formatting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3857
----
commit b3a3af7d92fb1f33a20cbfe2ca8c9bee76263542
Author: David Anderson <da...@alpinegizmo.com>
Date: 2017-05-09T15:23:46Z
[FLINK-6512][docs] improved code formatting in some examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3857: [FLINK-6512][docs] improved code formatting in some examp...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3857
@greghogan Yes, I think we should use spaces rather than tabs in code samples in the docs -- and fewer than 8. I looked around at all of the code in the docs, and made sure that all of it is now inside of a code highlighting block. I only changed indentation in cases where it really bothered me. Making the indentation 100% consistent didn't seem worth the trouble, and wouldn't very enforceable going forward (unless the highlight plugin is capable of doing the indentation for us).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3857: [FLINK-6512][docs] improved code formatting in some examp...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3857
@alpinegizmo is there a standard use here for tabs and spaces? This looks to assume that 1 tab = 8 spaces. If tabs are forcing too large and indentation why not use spaces everyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3857: [FLINK-6512][docs] improved code formatting in some examp...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3857
@alpinegizmo changes look good. Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3857: [FLINK-6512][docs] improved code formatting in som...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---