You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/13 17:46:55 UTC
[GitHub] [druid] drcrallen commented on issue #9166: use Caffeine instead of
Guava Cache
drcrallen commented on issue #9166: use Caffeine instead of Guava Cache
URL: https://github.com/apache/druid/pull/9166#issuecomment-573785349
Thanks for the PR! One note: catching blanket `Exception` often breaks `InterruptedException` intentions, especially if the catch just continues on through the loop. Can you please make sure you are more prescriptive on the exceptions caught?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org