[jira] [Comment Edited] (MESOS-1575) master sets failover timeout to 0 when framework requests a high value

["José Guilherme Vanz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698528#comment-14698528 ] 

José Guilherme Vanz edited comment on MESOS-1575 at 8/16/15 3:34 AM:
---------------------------------------------------------------------

I would like to solve this issue. Is this the code that I need to change https://github.com/apache/mesos/blob/master/src/master/master.cpp#L1050? Am I right?
What is the expected behavior? I should validate if the value is supported by the protobuf and refuse the other values?


was (Author: jvanz):
I would like to solve this issue. This is the code that I need to change https://github.com/apache/mesos/blob/master/src/master/master.cpp#L1050? Am I right?
What is the expected behavior? I should validate if the value is supported by the protobuf and refuse the other values?

> master sets failover timeout to 0 when framework requests a high value
> ----------------------------------------------------------------------
>
>                 Key: MESOS-1575
>                 URL: https://issues.apache.org/jira/browse/MESOS-1575
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Kevin Sweeney
>            Assignee: José Guilherme Vanz
>              Labels: newbie, twitter
>
> In response to a registered RPC we observed the following behavior:
> {noformat}
> W0709 19:07:32.982997 11400 master.cpp:612] Using the default value for 'failover_timeout' becausethe input value is invalid: Argument out of the range that a Duration can represent due to int64_t's size limit
> I0709 19:07:32.983008 11404 hierarchical_allocator_process.hpp:408] Deactivated framework 20140709-184342-119646400-5050-11380-0003
> I0709 19:07:32.983013 11400 master.cpp:617] Giving framework 20140709-184342-119646400-5050-11380-0003 0ns to failover
> I0709 19:07:32.983271 11404 master.cpp:2201] Framework failover timeout, removing framework 20140709-184342-119646400-5050-11380-0003
> I0709 19:07:32.983294 11404 master.cpp:2688] Removing framework 20140709-184342-119646400-5050-11380-0003
> I0709 19:07:32.983678 11404 hierarchical_allocator_process.hpp:363] Removed framework 20140709-184342-119646400-5050-11380-0003
> {noformat}
> This was using the following frameworkInfo.
> {code}
>     FrameworkInfo frameworkInfo = FrameworkInfo.newBuilder()
>         .setUser("test")
>         .setName("jvm")
>         .setFailoverTimeout(Long.MAX_VALUE)
>         .build();
> {code}
> Instead of silently defaulting large values to 0 the master should refuse to process the request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)